All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: linux-mips@linux-mips.org, linux-s390@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	David Howells <dhowells@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	Guan Xuetao <gxt@mprc.pku.edu.cn>, Jiri Slaby <jslaby@suse.cz>,
	Lennox Wu <lennox.wu@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	Jonas Bonn <jonas@southpole.se>,
	Chen Liqin <liqin.linux@gmail.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-am33-list@redhat.com, Russell King <linux@arm.linux.org.uk>,
	linux-c6x-dev@linux-c6, x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx>
Subject: Re: [3/4] exit_thread: accept a task parameter to be exited
Date: Fri, 25 Mar 2016 19:32:11 +1100 (AEDT)	[thread overview]
Message-ID: <3qWc3w0GCtz9sdm@ozlabs.org> (raw)
In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz>

On Thu, 2016-24-03 at 12:58:13 UTC, Jiri Slaby wrote:
> We need to call exit_thread from copy_process in a fail path.  So make
> it accept task_struct as a parameter.

If I'm counting right 22 of those are empty functions, so would it be a good
clean up to make it optional first?

cheers


WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: linux-mips@linux-mips.org, linux-s390@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	 Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	 David Howells <dhowells@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	 sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	Guan Xuetao <gxt@mprc.pku.edu.cn>, Jiri Slaby <jslaby@suse.cz>,
	Lennox Wu <lennox.wu@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	 Jonas Bonn <jonas@southpole.se>,
	Chen Liqin <liqin.linux@gmail.com>,
	 Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-am33-list@redhat.com,
	 Russell King <linux@arm.linux.org.uk>,
	linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx.de>,
	x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
	Ingo Molnar <mingo@redhat.com> ,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Salter <msalter@redhat.com>,
	 Matt Turner <mattst88@gmail.com>,
	linux-snps-arc@lists.infradead.org,
	 Haavard Skinnemoen <hskinnemoen@gmail.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	Fenghua Yu <fenghua.yu@intel.com>,
	James Hogan <james.hogan@imgtec.com>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	 user-mode-linux-devel@lists.sourceforge.net,
	Steven Miao <realmz6@gmail.com>,
	 Heiko Carstens <heiko.carstens@de.ibm.com>,
	Jeff Dike <jdike@addtoit.com>,
	 linux-alpha@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	Mikael Starvik <starvik@axis.com>,
	linux-m68k@lists.linux-m68k.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	user-mode-linux-user@lists.sourceforge.net,
	nios2-dev@lists.rocketboards.org,
	 Thomas Gleixner <tglx@linutronix.de>,
	linux-xtensa@linux-xtensa.org,  linux-metag@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Richard Henderson <rth@twiddle.net>,
	Chris Zankel <chris@zankel.net>,
	 Michal Simek <monstr@mon str.eu>,
	Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-cris-kernel@axis.com, Vineet Gupta <vgupta@synopsys.com>,
	linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Richard Kuo <rkuo@codeaurora.org>,
	Richard Weinberger <richard@nod.at>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ley Foon Tan <lftan@altera.com>,
	 Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [3/4] exit_thread: accept a task parameter to be exited
Date: Fri, 25 Mar 2016 19:32:11 +1100 (AEDT)	[thread overview]
Message-ID: <3qWc3w0GCtz9sdm@ozlabs.org> (raw)
In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz>

On Thu, 2016-24-03 at 12:58:13 UTC, Jiri Slaby wrote:
> We need to call exit_thread from copy_process in a fail path.  So make
> it accept task_struct as a parameter.

If I'm counting right 22 of those are empty functions, so would it be a good
clean up to make it optional first?

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: linux-mips@linux-mips.org, linux-s390@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	David Howells <dhowells@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Lennox Wu <lennox.wu@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	Jonas Bonn <jonas@southpole.se>,
	Chen Liqin <liqin.linux@gmail.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-am33-list@redhat.com, Russell King <linux@arm.linux.org.uk>,
	linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx.de>,
	x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
	Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>,
	linux-snps-arc@lists.infradead.org,
	Haavard Skinnemoen <hskinnemoen@gmail.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	Fenghua Yu <fenghua.yu@intel.com>,
	James Hogan <james.hogan@imgtec.com>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	user-mode-linux-devel@lists.sourceforge.net,
	Steven Miao <realmz6@gmail.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Jeff Dike <jdike@addtoit.com>,
	linux-alpha@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	Mikael Starvik <starvik@axis.com>,
	linux-m68k@lists.linux-m68k.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	user-mode-linux-user@lists.sourceforge.net,
	nios2-dev@lists.rocketboards.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-xtensa@linux-xtensa.org, linux-metag@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Richard Henderson <rth@twiddle.net>,
	Chris Zankel <chris@zankel.net>, Michal Simek <monstr@mon>,
	str.eu, Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-cris-kernel@axis.com, Vineet Gupta <vgupta@synopsys.com>,
	linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Richard Kuo <rkuo@codeaurora.org>,
	Richard Weinberger <richard@nod.at>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ley Foon Tan <lftan@altera.com>,
	Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [3/4] exit_thread: accept a task parameter to be exited
Date: Fri, 25 Mar 2016 19:32:11 +1100 (AEDT)	[thread overview]
Message-ID: <3qWc3w0GCtz9sdm@ozlabs.org> (raw)
Message-ID: <20160325083211.PilGcMZYdNQ742bK9SJpFKQik669dLJsnxnKawA8bkM@z> (raw)
In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz>

On Thu, 2016-24-03 at 12:58:13 UTC, Jiri Slaby wrote:
> We need to call exit_thread from copy_process in a fail path.  So make
> it accept task_struct as a parameter.

If I'm counting right 22 of those are empty functions, so would it be a good
clean up to make it optional first?

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: linux-mips@linux-mips.org, linux-s390@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	 Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	 David Howells <dhowells@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	 sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	Guan Xuetao <gxt@mprc.pku.edu.cn>, Jiri Slaby <jslaby@suse.cz>,
	Lennox Wu <lennox.wu@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	 Jonas Bonn <jonas@southpole.se>,
	Chen Liqin <liqin.linux@gmail.com>,
	 Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-am33-list@redhat.com,
	 Russell King <linux@arm.linux.org.uk>,
	linux-c6x-dev@linux-c6 x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx
Subject: Re: [3/4] exit_thread: accept a task parameter to be exited
Date: Fri, 25 Mar 2016 19:32:11 +1100 (AEDT)	[thread overview]
Message-ID: <3qWc3w0GCtz9sdm@ozlabs.org> (raw)
In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz>

On Thu, 2016-24-03 at 12:58:13 UTC, Jiri Slaby wrote:
> We need to call exit_thread from copy_process in a fail path.  So make
> it accept task_struct as a parameter.

If I'm counting right 22 of those are empty functions, so would it be a good
clean up to make it optional first?

cheers

WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Jiri Slaby <jslaby@suse.cz>, akpm@linux-foundation.org
Cc: linux-mips@linux-mips.org, linux-s390@vger.kernel.org,
	Rich Felker <dalias@libc.org>,
	Aurelien Jacquiot <a-jacquiot@ti.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	David Howells <dhowells@redhat.com>,
	Max Filippov <jcmvbkbc@gmail.com>,
	Paul Mackerras <paulus@samba.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	sparclinux@vger.kernel.org, linux-hexagon@vger.kernel.org,
	Guan Xuetao <gxt@mprc.pku.edu.cn>, Jiri Slaby <jslaby@suse.cz>,
	Lennox Wu <lennox.wu@gmail.com>,
	Hans-Christian Egtvedt <egtvedt@samfundet.no>,
	Jonas Bonn <jonas@southpole.se>,
	Chen Liqin <liqin.linux@gmail.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	linux-am33-list@redhat.com, Russell King <linux@arm.linux.org.uk>,
	linux-c6x-dev@linux-c6x.org,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	linux-sh@vger.kernel.org, Helge Deller <deller@gmx.de>,
	x86@kernel.org, "James E.J. Bottomley" <jejb@parisc-linux.org>,
	Ingo Molnar <mingo@redhat.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Mark Salter <msalter@redhat.com>,
	Matt Turner <mattst88@gmail.com>,
	linux-snps-arc@lists.infradead.org,
	Haavard Skinnemoen <hskinnemoen@gmail.com>,
	uclinux-h8-devel@lists.sourceforge.jp,
	Fenghua Yu <fenghua.yu@intel.com>,
	James Hogan <james.hogan@imgtec.com>,
	Chris Metcalf <cmetcalf@mellanox.com>,
	user-mode-linux-devel@lists.sourceforge.net,
	Steven Miao <realmz6@gmail.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	Jeff Dike <jdike@addtoit.com>,
	linux-alpha@vger.kernel.org,
	adi-buildroot-devel@lists.sourceforge.net,
	Mikael Starvik <starvik@axis.com>,
	linux-m68k@lists.linux-m68k.org,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	user-mode-linux-user@lists.sourceforge.net,
	nios2-dev@lists.rocketboards.org,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-xtensa@linux-xtensa.org, linux-metag@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Richard Henderson <rth@twiddle.net>,
	Chris Zankel <chris@zankel.net>, Michal Simek <monstr@mon>,
	str.eu, , Tony Luck <tony.luck@intel.com>,
	linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org,
	linux-cris-kernel@axis.com, Vineet Gupta <vgupta@synopsys.com>,
	linux-kernel@vger.kernel.org, Ralf Baechle <ralf@linux-mips.org>,
	Richard Kuo <rkuo@codeaurora.org>,
	Richard Weinberger <richard@nod.at>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Ley Foon Tan <lftan@altera.com>,
	Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
	linuxppc-dev@lists.ozlabs.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [3/4] exit_thread: accept a task parameter to be exited
Date: Fri, 25 Mar 2016 19:32:11 +1100 (AEDT)	[thread overview]
Message-ID: <3qWc3w0GCtz9sdm@ozlabs.org> (raw)
In-Reply-To: <1458824294-29733-1-git-send-email-jslaby@suse.cz>

On Thu, 2016-24-03 at 12:58:13 UTC, Jiri Slaby wrote:
> We need to call exit_thread from copy_process in a fail path.  So make
> it accept task_struct as a parameter.

If I'm counting right 22 of those are empty functions, so would it be a good
clean up to make it optional first?

cheers


  parent reply	other threads:[~2016-03-25  8:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-24 12:58 [PATCH 3/4] exit_thread: accept a task parameter to be exited Jiri Slaby
2016-03-24 12:58 ` Jiri Slaby
2016-03-24 12:58 ` Jiri Slaby
2016-03-24 12:58 ` Jiri Slaby
2016-03-24 12:58 ` [PATCH 4/4] fork: free thread in copy_process on failure Jiri Slaby
2016-03-24 13:03 ` [PATCH 3/4] exit_thread: accept a task parameter to be exited Peter Zijlstra
2016-03-24 13:03   ` Peter Zijlstra
2016-03-24 13:03   ` Peter Zijlstra
2016-03-24 13:03   ` Peter Zijlstra
2016-03-24 13:05   ` Jiri Slaby
2016-03-24 13:05     ` Jiri Slaby
2016-03-24 13:05     ` Jiri Slaby
2016-03-24 13:05     ` Jiri Slaby
2016-03-24 15:36 ` Russell King - ARM Linux
2016-03-24 15:36   ` Russell King - ARM Linux
2016-03-24 15:36   ` Russell King - ARM Linux
2016-03-24 15:36   ` Russell King - ARM Linux
2016-03-25  8:32 ` Michael Ellerman [this message]
2016-03-25  8:32   ` [3/4] " Michael Ellerman
2016-03-25  8:32   ` Michael Ellerman
2016-03-25  8:32   ` Michael Ellerman
2016-03-25  8:32   ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3qWc3w0GCtz9sdm@ozlabs.org \
    --to=mpe@ellerman.id.au \
    --cc=a-jacquiot@ti.com \
    --cc=akpm@linux-foundation.org \
    --cc=catalin.marinas@arm.com \
    --cc=dalias@libc.org \
    --cc=deller@gmx \
    --cc=dhowells@redhat.com \
    --cc=egtvedt@samfundet.no \
    --cc=gxt@mprc.pku.edu.cn \
    --cc=hpa@zytor.com \
    --cc=jcmvbkbc@gmail.com \
    --cc=jesper.nilsson@axis.com \
    --cc=jonas@southpole.se \
    --cc=jslaby@suse.cz \
    --cc=lennox.wu@gmail.com \
    --cc=linux-am33-list@redhat.com \
    --cc=linux-c6x-dev@linux-c6 \
    --cc=linux-hexagon@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.linux@gmail.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=sparclinux@vger.kernel.org \
    --cc=will.deacon@arm.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.