From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Balbir Singh <bsingharora@gmail.com>,
vdavydov.dev@gmail.com, oss@buserror.net
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [v3,1/3] powerpc/mm/book(e)(3s)/64: Add page table accounting
Date: Thu, 8 Jun 2017 14:07:36 +1000 (AEST) [thread overview]
Message-ID: <3wjsMX2r61z9s8F@ozlabs.org> (raw)
In-Reply-To: <20170502051706.19043-2-bsingharora@gmail.com>
On Tue, 2017-05-02 at 05:17:04 UTC, Balbir Singh wrote:
> Introduce a helper pgtable_gfp_flags() which
> just returns the current gfp flags and adds
> __GFP_ACCOUNT to account for page table allocation.
> The generic helper is added to include/asm/pgalloc.h
> and has two variants - WARNING ugly bits ahead
>
> 1. If the header is included from a module, no check
> for mm == &init_mm is done, since init_mm is not
> exported
> 2. For kernel includes, the check is done and required
> see (3e79ec7 arch: x86: charge page tables to kmemcg)
>
> The fundamental assumption is that no module should be
> doing pgd/pud/pmd and pte alloc's on behalf of init_mm
> directly.
>
> NOTE: This adds an overhead to pmd/pud/pgd allocations
> similar to x86. The other alternative was to implement
> pmd_alloc_kernel/pud_alloc_kernel and pgd_alloc_kernel
> with their offset variants.
>
> For 4k page size, pte_alloc_one no longer calls
> pte_alloc_one_kernel.
>
> Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/de3b87611dd1f3c00f4e42fe298457
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Balbir Singh <bsingharora@gmail.com>,
vdavydov.dev@gmail.com, oss@buserror.net
Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [v3,1/3] powerpc/mm/book(e)(3s)/64: Add page table accounting
Date: Thu, 8 Jun 2017 14:07:36 +1000 (AEST) [thread overview]
Message-ID: <3wjsMX2r61z9s8F@ozlabs.org> (raw)
In-Reply-To: <20170502051706.19043-2-bsingharora@gmail.com>
On Tue, 2017-05-02 at 05:17:04 UTC, Balbir Singh wrote:
> Introduce a helper pgtable_gfp_flags() which
> just returns the current gfp flags and adds
> __GFP_ACCOUNT to account for page table allocation.
> The generic helper is added to include/asm/pgalloc.h
> and has two variants - WARNING ugly bits ahead
>
> 1. If the header is included from a module, no check
> for mm == &init_mm is done, since init_mm is not
> exported
> 2. For kernel includes, the check is done and required
> see (3e79ec7 arch: x86: charge page tables to kmemcg)
>
> The fundamental assumption is that no module should be
> doing pgd/pud/pmd and pte alloc's on behalf of init_mm
> directly.
>
> NOTE: This adds an overhead to pmd/pud/pgd allocations
> similar to x86. The other alternative was to implement
> pmd_alloc_kernel/pud_alloc_kernel and pgd_alloc_kernel
> with their offset variants.
>
> For 4k page size, pte_alloc_one no longer calls
> pte_alloc_one_kernel.
>
> Signed-off-by: Balbir Singh <bsingharora@gmail.com>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/de3b87611dd1f3c00f4e42fe298457
cheers
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-06-08 4:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-02 5:17 [PATCH v3 0/3] Implement page table accounting for powerpc Balbir Singh
2017-05-02 5:17 ` Balbir Singh
2017-05-02 5:17 ` [PATCH v3 1/3] powerpc/mm/book(e)(3s)/64: Add page table accounting Balbir Singh
2017-05-02 5:17 ` Balbir Singh
2017-06-08 4:07 ` Michael Ellerman [this message]
2017-06-08 4:07 ` [v3,1/3] " Michael Ellerman
2017-05-02 5:17 ` [PATCH v3 2/3] powerpc/mm/book(e)(3s)/32: " Balbir Singh
2017-05-02 5:17 ` Balbir Singh
2017-05-02 5:17 ` [PATCH v3 3/3] powerpc/mm/hugetlb: Add support for page accounting Balbir Singh
2017-05-02 5:17 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3wjsMX2r61z9s8F@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=bsingharora@gmail.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oss@buserror.net \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.