From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Laurent Vivier <lvivier@redhat.com>, kvm-ppc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Cédric Le Goater" <clg@kaod.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()
Date: Fri, 22 Dec 2017 11:24:04 +0000 [thread overview]
Message-ID: <3z35kD3TMXz9sMN@ozlabs.org> (raw)
In-Reply-To: <20171212172356.2397-1-lvivier@redhat.com>
On Tue, 2017-12-12 at 17:23:56 UTC, Laurent Vivier wrote:
> When we migrate a VM from a POWER8 host (XICS) to a POWER9 host
> (XICS-on-XIVE), we have an error:
>
> qemu-kvm: Unable to restore KVM interrupt controller state \
> (0xff000000) for CPU 0: Invalid argument
>
> This is because kvmppc_xics_set_icp() checks the new state
> is internaly consistent, and especially:
>
> ...
> 1129 if (xisr = 0) {
> 1130 if (pending_pri != 0xff)
> 1131 return -EINVAL;
> ...
>
> On the other side, kvmppc_xive_get_icp() doesn't set
> neither the pending_pri value, nor the xisr value (set to 0)
> (and kvmppc_xive_set_icp() ignores the pending_pri value)
>
> As xisr is 0, pending_pri must be set to 0xff.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/7333b5aca412d6ad02667b5a513485
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Laurent Vivier <lvivier@redhat.com>, kvm-ppc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Cédric Le Goater" <clg@kaod.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp()
Date: Fri, 22 Dec 2017 22:24:04 +1100 (AEDT) [thread overview]
Message-ID: <3z35kD3TMXz9sMN@ozlabs.org> (raw)
In-Reply-To: <20171212172356.2397-1-lvivier@redhat.com>
On Tue, 2017-12-12 at 17:23:56 UTC, Laurent Vivier wrote:
> When we migrate a VM from a POWER8 host (XICS) to a POWER9 host
> (XICS-on-XIVE), we have an error:
>
> qemu-kvm: Unable to restore KVM interrupt controller state \
> (0xff000000) for CPU 0: Invalid argument
>
> This is because kvmppc_xics_set_icp() checks the new state
> is internaly consistent, and especially:
>
> ...
> 1129 if (xisr == 0) {
> 1130 if (pending_pri != 0xff)
> 1131 return -EINVAL;
> ...
>
> On the other side, kvmppc_xive_get_icp() doesn't set
> neither the pending_pri value, nor the xisr value (set to 0)
> (and kvmppc_xive_set_icp() ignores the pending_pri value)
>
> As xisr is 0, pending_pri must be set to 0xff.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/7333b5aca412d6ad02667b5a513485
cheers
next prev parent reply other threads:[~2017-12-22 11:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 17:23 [PATCH] KVM: PPC: Book3S HV: Fix pending_pri value in kvmppc_xive_get_icp() Laurent Vivier
2017-12-12 17:23 ` Laurent Vivier
2017-12-12 20:18 ` Benjamin Herrenschmidt
2017-12-12 20:18 ` Benjamin Herrenschmidt
2017-12-22 11:24 ` Michael Ellerman [this message]
2017-12-22 11:24 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3z35kD3TMXz9sMN@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=clg@kaod.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lvivier@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.