From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: Michael Rubin <mrubin@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 01/13] writeback: revert 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b
Date: Tue, 15 Jan 2008 20:36:38 +0800 [thread overview]
Message-ID: <400401290.18034@ustc.edu.cn> (raw)
Message-ID: <20080115124758.142052041@mail.ustc.edu.cn> (raw)
In-Reply-To: 20080115123637.518924046@mail.ustc.edu.cn
[-- Attachment #1: revert-more_io.patch --]
[-- Type: text/plain, Size: 2545 bytes --]
Revert 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b.
Signed-off-by: Fengguang Wu <wfg@mail.ustc.edu.cn>
---
fs/fs-writeback.c | 2 --
include/linux/writeback.h | 1 -
mm/page-writeback.c | 9 +++------
3 files changed, 3 insertions(+), 9 deletions(-)
Index: linux-mm/include/linux/writeback.h
===================================================================
--- linux-mm.orig/include/linux/writeback.h
+++ linux-mm/include/linux/writeback.h
@@ -62,7 +62,6 @@ struct writeback_control {
unsigned for_reclaim:1; /* Invoked from the page allocator */
unsigned for_writepages:1; /* This is a writepages() call */
unsigned range_cyclic:1; /* range_start is cyclic */
- unsigned more_io:1; /* more io to be dispatched */
};
/*
Index: linux-mm/fs/fs-writeback.c
===================================================================
--- linux-mm.orig/fs/fs-writeback.c
+++ linux-mm/fs/fs-writeback.c
@@ -475,8 +475,6 @@ int generic_sync_sb_inodes(struct super_
if (wbc->nr_to_write <= 0)
break;
}
- if (!list_empty(&sb->s_more_io))
- wbc->more_io = 1;
spin_unlock(&inode_lock);
return ret; /* Leave any unwritten inodes on s_io */
}
Index: linux-mm/mm/page-writeback.c
===================================================================
--- linux-mm.orig/mm/page-writeback.c
+++ linux-mm/mm/page-writeback.c
@@ -567,7 +567,6 @@ static void background_writeout(unsigned
global_page_state(NR_UNSTABLE_NFS) < background_thresh
&& min_pages <= 0)
break;
- wbc.more_io = 0;
wbc.encountered_congestion = 0;
wbc.nr_to_write = MAX_WRITEBACK_PAGES;
wbc.pages_skipped = 0;
@@ -575,9 +574,8 @@ static void background_writeout(unsigned
min_pages -= MAX_WRITEBACK_PAGES - wbc.nr_to_write;
if (wbc.nr_to_write > 0 || wbc.pages_skipped > 0) {
/* Wrote less than expected */
- if (wbc.encountered_congestion || wbc.more_io)
- congestion_wait(WRITE, HZ/10);
- else
+ congestion_wait(WRITE, HZ/10);
+ if (!wbc.encountered_congestion)
break;
}
}
@@ -642,12 +640,11 @@ static void wb_kupdate(unsigned long arg
global_page_state(NR_UNSTABLE_NFS) +
(inodes_stat.nr_inodes - inodes_stat.nr_unused);
while (nr_to_write > 0) {
- wbc.more_io = 0;
wbc.encountered_congestion = 0;
wbc.nr_to_write = MAX_WRITEBACK_PAGES;
writeback_inodes(&wbc);
if (wbc.nr_to_write > 0) {
- if (wbc.encountered_congestion || wbc.more_io)
+ if (wbc.encountered_congestion)
congestion_wait(WRITE, HZ/10);
else
break; /* All the old data is written */
--
next prev parent reply other threads:[~2008-01-15 12:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 12:36 [PATCH 00/13] writeback bug fixes and simplifications take 2 Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 18:33 ` Michael Rubin
2008-01-16 2:18 ` Fengguang Wu
2008-01-16 2:18 ` Fengguang Wu
2008-01-18 7:51 ` Michael Rubin
2008-01-18 8:27 ` Fengguang Wu
2008-01-18 8:27 ` Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu [this message]
2008-01-15 12:36 ` [PATCH 01/13] writeback: revert 2e6883bdf49abd0e7f0d9b6297fc3be7ebb2250b Fengguang Wu
2008-01-15 12:36 ` [PATCH 02/13] writeback: clear PAGECACHE_TAG_DIRTY for truncated page in block_write_full_page() Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 03/13] writeback: introduce writeback_control.more_io Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 04/13] writeback: introduce super_block.s_more_io_wait Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 05/13] writeback: merge duplicate code into writeback_some_pages() Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 06/13] writeback: defer writeback on not-all-pages-written Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 07/13] writeback: defer writeback on locked inode Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 08/13] writeback: defer writeback on locked buffers Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 09/13] writeback: requeue_io() on redirtied inode Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-16 8:13 ` David Chinner
2008-01-17 4:22 ` Fengguang Wu
2008-01-17 4:22 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 10/13] writeback: introduce queue_dirty() Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 11/13] writeback: queue_dirty() on memory-backed bdi Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 12/13] writeback: remove redirty_tail() Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
2008-01-15 12:36 ` [PATCH 13/13] writeback: cleanup __sync_single_inode() Fengguang Wu
2008-01-15 12:36 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=400401290.18034@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=mrubin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.