[PATCH] possible fix for misbehaving hdsp

[PATCH] possible fix for misbehaving hdsp

[Thomas Charbonnel]

[-- Attachment #1: Type: text/plain, Size: 120 bytes --]

Hi,

Could people experiencing problems with their hdsp (namely Tim and Paul) 
try the attached patch ?

Thanks,
Thomas

[-- Attachment #2: pci_latency_timer.patch --]
[-- Type: text/plain, Size: 762 bytes --]

--- hdsp.c.old	2004-01-26 14:34:48.000000000 +0100
+++ hdsp.c	2004-01-26 14:51:18.000000000 +0100
@@ -4982,6 +4982,16 @@
 	tasklet_init(&hdsp->midi_tasklet, hdsp_midi_tasklet, (unsigned long)hdsp);
 	
 	pci_read_config_word(hdsp->pci, PCI_CLASS_REVISION, &hdsp->firmware_rev);
+	
+	/* From Martin Björnsen :
+	    "It is important that the card's latency timer register in
+	    the PCI configuration space is set to a value much larger
+	    than 0 by the computer's BIOS or the driver.
+	    The windows driver always sets this 8 bit register [...]
+	    to its maximum 255 to avoid problems with some computers."
+	*/
+	pci_write_config_byte(hdsp->pci, PCI_LATENCY_TIMER, 0xFF);
+	
 	strcpy(card->driver, "H-DSP");
 	strcpy(card->mixername, "Xilinx FPGA");
 

Re: [PATCH] possible fix for misbehaving hdsp

[Takashi Iwai]

At Mon, 26 Jan 2004 14:54:42 +0100,
Thomas Charbonnel wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> Hi,
> 
> Could people experiencing problems with their hdsp (namely Tim and Paul) 
> try the attached patch ?

it includes a non-ASCII letter

> +	/* From Martin Bj?en :

can it be replaced with oe or something else?


Takashi


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

Re: [PATCH] possible fix for misbehaving hdsp

[Thomas Charbonnel]

Takashi Iwai a écrit :
> At Mon, 26 Jan 2004 14:54:42 +0100,
> Thomas Charbonnel wrote:
> 
>>[1  <text/plain; us-ascii (7bit)>]
>>Hi,
>>
>>Could people experiencing problems with their hdsp (namely Tim and Paul) 
>>try the attached patch ?
> 
> 
> it includes a non-ASCII letter
> 
> 
>>+	/* From Martin Bj?en :
> 
> 
> can it be replaced with oe or something else?
> 
> 
> Takashi
> 
> 

Of course -> Martin Bjoernsen.
IIRC, there is another occurence of this in the driver code, if you want 
to fix it also.

Thanks,
Thomas



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

Re: [PATCH] possible fix for misbehaving hdsp

[Takashi Iwai]

At Mon, 26 Jan 2004 15:54:06 +0100,
Thomas Charbonnel wrote:
> 
> Takashi Iwai a écrit :
> > At Mon, 26 Jan 2004 14:54:42 +0100,
> > Thomas Charbonnel wrote:
> > 
> >>[1  <text/plain; us-ascii (7bit)>]
> >>Hi,
> >>
> >>Could people experiencing problems with their hdsp (namely Tim and Paul) 
> >>try the attached patch ?
> > 
> > 
> > it includes a non-ASCII letter
> > 
> > 
> >>+	/* From Martin Bj?en :
> > 
> > 
> > can it be replaced with oe or something else?
> > 
> > 
> > Takashi
> > 
> > 
> 
> Of course -> Martin Bjoernsen.

ok, i applied the patch to cvs.

> IIRC, there is another occurence of this in the driver code, if you want 
> to fix it also.

yep, there it is.  but i don't think it's necessary to remove it
unless someone complains :)

i asked it because i'm using UTF-8 as default now.
the handling of non-ASCII via cvs/bk is very sensitive.


thanks,

Takashi


-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn

Re: [PATCH] possible fix for misbehaving hdsp

[Tim Blechmann]

> Could people experiencing problems with their hdsp (namely Tim and
> Paul) try the attached patch ?
i tried the patch you sent me ... no success ... i tried to play a
soundfile with aplay using different period-sizes ...
the file always had the same distortions ...
btw, the patch just changed the default pci latency ... i did that a few
weeks ago manually, using every setup i could think of ... it doesn't
seem to be related to this...

i'm still confused of the third line (dmesg):

cs: cb_alloc(bus 7): vendor 0x10ee, device 0x3fc5
PCI: Enabling device 07:00.0 (0080 -> 0082)
ALSA ../../alsa-kernel/pci/rme9652/hdsp.c:663: Hammerfall-DSP: no
Digiface or Multiface connected! 
ALSA ../../alsa-kernel/pci/rme9652/hdsp.c:5052: card initialization
pending : waiting for firmware

alsa doesn't seem to realize that the multiface is connected ... is this
ok?


and:
ALSA ../../alsa-kernel/pci/rme9652/hdsp.c:807: wait for FIFO status <= 0
failed after 30 iterations
ALSA../../alsa-kernel/pci/rme9652/hdsp.c:4711: initializing firmware
upload ALSA ../../alsa-kernel/pci/rme9652/hdsp.c:678: loading firmware
ALSA../../alsa-kernel/pci/rme9652/hdsp.c:716: finished firmware loading

when running hdsploader i usually get the first message ...

btw, paul, is the patch working on your setup?

cheers...

 Tim                          mailto:TimBlechmann@gmx.de
                              ICQ: 96771783
--
The only people for me are the mad ones, the ones who are mad to live,
mad to talk, mad to be saved, desirous of everything at the same time,
the ones who never yawn or say a commonplace thing, but burn, burn,
burn, like fabulous yellow roman candles exploding like spiders across
the stars and in the middle you see the blue centerlight pop and
everybody goes "Awww!"
                                                          Jack Kerouac



-- 
 Tim                          mailto:TimBlechmann@gmx.de
                              ICQ: 96771783
--
The only people for me are the mad ones, the ones who are mad to live,
mad to talk, mad to be saved, desirous of everything at the same time,
the ones who never yawn or say a commonplace thing, but burn, burn,
burn, like fabulous yellow roman candles exploding like spiders across
the stars and in the middle you see the blue centerlight pop and
everybody goes "Awww!"
                                                          Jack Kerouac



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn