From: Jeff Garzik <jgarzik@pobox.com>
To: Leonid Grossman <leonid.grossman@s2io.com>
Cc: "'Stephen Hemminger'" <shemminger@osdl.org>,
"'Andi Kleen'" <ak@suse.de>,
netdev@oss.sgi.com, raghavendra.koushik@s2io.com
Subject: Re: Submission for S2io 10GbE driver
Date: Tue, 27 Jan 2004 01:08:32 -0500 [thread overview]
Message-ID: <40160060.4010709@pobox.com> (raw)
In-Reply-To: <001801c3e497$010671a0$0400a8c0@S2IOtech.com>
Leonid Grossman wrote:
> The loopback test is there as a part of the ethtool's diagnostic option.
>
>
> There are pros and cons of having the test in there I guess, anyone else
> has an opinion on this?
>
> Do other net drivers normally support loopback and other diag tests as a
> part of the ethtool support,
> or they provide little/no support for the option and ship a standalone
> diag program instead?
The ethtool diag stuff is more of a quick sanity test than anything
exhaustive.
I definitely want to discourage tons of test code in drivers, as its
code that users will almost-never run, it bloats the driver, and can be
done with a special diag-only driver or diag program (or a combination
of both).
A lot of the 10/100 drivers originated from Donald Becker, who typically
creates a userland (i.e. separate) diag program for each driver he writes.
Jeff
next prev parent reply other threads:[~2004-01-27 6:08 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 21:22 FW: Submission for S2io 10GbE driver Leonid Grossman
2004-01-23 21:54 ` Stephen Hemminger
2004-01-23 21:58 ` Leonid Grossman
2004-01-23 22:22 ` FW: " Andi Kleen
2004-01-24 0:21 ` Stephen Hemminger
2004-01-27 5:32 ` Leonid Grossman
2004-01-27 6:08 ` Jeff Garzik [this message]
2004-01-27 6:19 ` Leonid Grossman
2004-02-04 20:44 ` FW: " Leonid Grossman
2004-02-05 0:49 ` Grant Grundler
2004-02-05 1:14 ` Leonid Grossman
2004-02-16 21:16 ` Leonid Grossman
2004-02-16 22:12 ` Jeff Garzik
2004-02-16 23:53 ` Leonid Grossman
2004-02-17 0:11 ` Christoph Hellwig
2004-02-17 0:16 ` Stephen Hemminger
2004-02-28 15:08 ` Submission #3 " Leonid Grossman
2004-02-28 20:21 ` Jeff Garzik
2004-03-12 21:55 ` ravinandan arakali
2004-03-13 2:30 ` Jeff Garzik
2004-03-20 4:35 ` Submission #4 " Leonid Grossman
2004-03-20 9:56 ` Jeff Garzik
2004-03-20 10:00 ` Jeff Garzik
2004-03-22 19:36 ` ravinandan arakali
2004-03-22 19:43 ` Jeff Garzik
2004-03-20 10:48 ` Christoph Hellwig
2004-02-05 1:32 ` FW: Submission " Andi Kleen
2004-02-05 1:51 ` Anton Blanchard
2004-02-05 2:46 ` Leonid Grossman
2004-02-05 3:25 ` Anton Blanchard
2004-02-05 9:27 ` Jeff Garzik
2004-02-05 9:29 ` Jeff Garzik
2004-02-05 22:09 ` Leonid Grossman
2004-02-05 22:34 ` Grant Grundler
2004-02-05 23:23 ` Jes Sorensen
2004-01-24 0:38 ` Francois Romieu
2004-01-24 3:14 ` jamal
2004-01-24 5:10 ` Leonid Grossman
2004-01-24 14:58 ` Andi Kleen
2004-01-24 17:54 ` jamal
2004-01-24 19:52 ` Leonid Grossman
2004-01-25 19:07 ` jamal
2004-01-25 17:56 ` Leonid Grossman
2004-01-24 18:00 ` jamal
2004-01-24 20:04 ` Leonid Grossman
2004-01-25 19:14 ` jamal
-- strict thread matches above, loose matches on Subject: below --
2004-02-19 7:16 raghavendra.koushik
2004-02-19 8:14 ` Jeff Garzik
2004-02-20 2:33 ` ravinandan arakali
[not found] <403573B5.4050100@pobox.com>
2004-02-20 2:59 ` ravinandan arakali
2004-02-20 3:30 ` Jeff Garzik
2004-02-25 6:03 raghavendra.koushik
2004-02-26 7:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40160060.4010709@pobox.com \
--to=jgarzik@pobox.com \
--cc=ak@suse.de \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.