From: Jeff Garzik <jgarzik@pobox.com>
To: Leonid Grossman <leonid.grossman@s2io.com>
Cc: netdev@oss.sgi.com,
"'ravinandan arakali'" <ravinandan.arakali@s2io.com>,
raghavendra.koushik@s2io.com
Subject: Re: Submission #4 for S2io 10GbE driver
Date: Sat, 20 Mar 2004 04:56:10 -0500 [thread overview]
Message-ID: <405C153A.2020809@pobox.com> (raw)
In-Reply-To: <001001c40e34$d2c3c4b0$0300a8c0@S2IOtech.com>
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
applied to 2.6, thanks.
Note I made the attached changes, otherwise the build would throw a
bunch of errors and warnings. Also, I merged it into
drivers/net/s2io{.c,.h,-regs.h} since there isn't a need for a separate
directory for just three files.
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1290 bytes --]
===== drivers/net/s2io.h 1.1 vs 1.2 =====
--- 1.1/drivers/net/s2io.h Sat Mar 20 04:38:16 2004
+++ 1.2/drivers/net/s2io.h Sat Mar 20 04:47:53 2004
@@ -14,8 +14,8 @@
#define _S2IO_H
#define TBD 0
-#define BIT(loc) (((u64)0x8000000000000000ULL) >> loc)
-#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz))
+#define BIT(loc) (1ULL << (loc))
+#define vBIT(val, loc, sz) (((u64)val) << (64-loc-sz))
#ifndef BOOL
#define BOOL int
@@ -531,7 +531,7 @@
RxD_t rxd[MAX_RXDS_PER_BLOCK];
u64 reserved_0;
-#define END_OF_BLOCK 0xFEFFFFFFFFFFFFFF
+#define END_OF_BLOCK 0xFEFFFFFFFFFFFFFFULL
u64 reserved_1; /* 0xFEFFFFFFFFFFFFFF to mark last Rxd in this blk */
u64 reserved_2_pNext_RxD_block; /*@ Logical ptr to next */
u64 pNext_RxD_Blk_physical; /* Buff0_ptr.
@@ -738,7 +738,7 @@
u16 last_link_state;
#define LINK_DOWN 1
#define LINK_UP 2
-} nic_t __cacheline_aligned;
+} nic_t;
#define RESET_ERROR 1;
#define CMD_ERROR 2;
===== drivers/net/s2io.c 1.1 vs 1.2 =====
--- 1.1/drivers/net/s2io.c Sat Mar 20 04:38:15 2004
+++ 1.2/drivers/net/s2io.c Sat Mar 20 04:47:53 2004
@@ -65,7 +65,7 @@
/* local include */
#include "s2io.h"
-#include "regs.h"
+#include "s2io-regs.h"
/* S2io Driver name & version. */
static char s2io_driver_name[] = "s2io";
next prev parent reply other threads:[~2004-03-20 9:56 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-23 21:22 FW: Submission for S2io 10GbE driver Leonid Grossman
2004-01-23 21:54 ` Stephen Hemminger
2004-01-23 21:58 ` Leonid Grossman
2004-01-23 22:22 ` FW: " Andi Kleen
2004-01-24 0:21 ` Stephen Hemminger
2004-01-27 5:32 ` Leonid Grossman
2004-01-27 6:08 ` Jeff Garzik
2004-01-27 6:19 ` Leonid Grossman
2004-02-04 20:44 ` FW: " Leonid Grossman
2004-02-05 0:49 ` Grant Grundler
2004-02-05 1:14 ` Leonid Grossman
2004-02-16 21:16 ` Leonid Grossman
2004-02-16 22:12 ` Jeff Garzik
2004-02-16 23:53 ` Leonid Grossman
2004-02-17 0:11 ` Christoph Hellwig
2004-02-17 0:16 ` Stephen Hemminger
2004-02-28 15:08 ` Submission #3 " Leonid Grossman
2004-02-28 20:21 ` Jeff Garzik
2004-03-12 21:55 ` ravinandan arakali
2004-03-13 2:30 ` Jeff Garzik
2004-03-20 4:35 ` Submission #4 " Leonid Grossman
2004-03-20 9:56 ` Jeff Garzik [this message]
2004-03-20 10:00 ` Jeff Garzik
2004-03-22 19:36 ` ravinandan arakali
2004-03-22 19:43 ` Jeff Garzik
2004-03-20 10:48 ` Christoph Hellwig
2004-02-05 1:32 ` FW: Submission " Andi Kleen
2004-02-05 1:51 ` Anton Blanchard
2004-02-05 2:46 ` Leonid Grossman
2004-02-05 3:25 ` Anton Blanchard
2004-02-05 9:27 ` Jeff Garzik
2004-02-05 9:29 ` Jeff Garzik
2004-02-05 22:09 ` Leonid Grossman
2004-02-05 22:34 ` Grant Grundler
2004-02-05 23:23 ` Jes Sorensen
2004-01-24 0:38 ` Francois Romieu
2004-01-24 3:14 ` jamal
2004-01-24 5:10 ` Leonid Grossman
2004-01-24 14:58 ` Andi Kleen
2004-01-24 17:54 ` jamal
2004-01-24 19:52 ` Leonid Grossman
2004-01-25 19:07 ` jamal
2004-01-25 17:56 ` Leonid Grossman
2004-01-24 18:00 ` jamal
2004-01-24 20:04 ` Leonid Grossman
2004-01-25 19:14 ` jamal
[not found] <405C239B.3070804@pobox.com>
2004-03-20 15:42 ` Submission #4 " Leonid Grossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=405C153A.2020809@pobox.com \
--to=jgarzik@pobox.com \
--cc=leonid.grossman@s2io.com \
--cc=netdev@oss.sgi.com \
--cc=raghavendra.koushik@s2io.com \
--cc=ravinandan.arakali@s2io.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.