[parisc-linux] error?

[parisc-linux] error?

[Naresh Kumar]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Hi,
I noticed in the function 'linux-2.6/drivers/parisc/lba_pci.c:
lba_pat_resources( )' the following lines:

---------------------------------------------------------------
  case PAT_GMMIO:

   r = &(lba_dev->hba.gmmio_space);
   r->name   = "LBA GMMIO";
   r->start  = p->start;
   r->end    = p->end;
   r->flags  = IORESOURCE_MEM;
   r->parent = r->sibling = r->child = NULL;
   break;
   lba_dev->gmmio_base = p->start;
   break;

  case PAT_NPIOP:
    printk(KERN_WARNING MODULE_NAME
    " range[%d] : ignoring NPIOP (0x%lx)\n",
    i, p->start);
   break;
-------------------------------------------------------------------

Please note the extra lines after the 'break;'. The version of
'lba_pci.c' is 1.7. Seems to have happened due to oversight.

Thanks,
Naresh.


[-- Attachment #2: Type: text/html, Size: 1159 bytes --]

Re: [parisc-linux] error?

[Grant Grundler]

On Tue, Jan 27, 2004 at 03:16:16PM +0530, Naresh Kumar wrote:
>    r->end    = p->end;
>    r->flags  = IORESOURCE_MEM;
>    r->parent = r->sibling = r->child = NULL;
>    break;
>    lba_dev->gmmio_base = p->start;
>    break;
> 
>   case PAT_NPIOP:
>     printk(KERN_WARNING MODULE_NAME
>     " range[%d] : ignoring NPIOP (0x%lx)\n",
>     i, p->start);
>    break;
> -------------------------------------------------------------------
> 
> Please note the extra lines after the 'break;'. The version of
> 'lba_pci.c' is 1.7. Seems to have happened due to oversight.

Those are "extra"?
The version of code in linux-2.4 CVS has:
                case PAT_GMMIO:
                        printk(KERN_WARNING MODULE_NAME
                                " range[%d] : ignoring GMMIO (0x%lx)\n",
                                i, p->start);
                        lba_dev->gmmio_base = p->start;
                        break;

The code you quoted is missing the "case PAT_GMMIO" and printk.

thanks,
grant

Re: [parisc-linux] error?

[Matthew Wilcox]

On Tue, Jan 27, 2004 at 10:22:56AM -0700, Grant Grundler wrote:
> On Tue, Jan 27, 2004 at 03:16:16PM +0530, Naresh Kumar wrote:
> >    r->end    = p->end;
> >    r->flags  = IORESOURCE_MEM;
> >    r->parent = r->sibling = r->child = NULL;
> >    break;
> >    lba_dev->gmmio_base = p->start;
> >    break;
> > 
> >   case PAT_NPIOP:
> >     printk(KERN_WARNING MODULE_NAME
> >     " range[%d] : ignoring NPIOP (0x%lx)\n",
> >     i, p->start);
> >    break;
> > -------------------------------------------------------------------
> > 
> > Please note the extra lines after the 'break;'. The version of
> > 'lba_pci.c' is 1.7. Seems to have happened due to oversight.
> 
> Those are "extra"?
> The version of code in linux-2.4 CVS has:
>                 case PAT_GMMIO:
>                         printk(KERN_WARNING MODULE_NAME
>                                 " range[%d] : ignoring GMMIO (0x%lx)\n",
>                                 i, p->start);
>                         lba_dev->gmmio_base = p->start;
>                         break;
> 
> The code you quoted is missing the "case PAT_GMMIO" and printk.

The bit he's referring to is:

>    break;
>    lba_dev->gmmio_base = p->start;
>    break;

which is clearly bogus.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

Re: [parisc-linux] error?

[Naresh Kumar]

Grant,
I was referring to linux-2.6. There are two 'break' statements in 'case
PAT_GMMIO:'. Removing the first 'break' will do.
Regards,
Naresh.


> Those are "extra"?
> The version of code in linux-2.4 CVS has:
>                 case PAT_GMMIO:
>                         printk(KERN_WARNING MODULE_NAME
>                                 " range[%d] : ignoring GMMIO (0x%lx)\n",
>                                 i, p->start);
>                         lba_dev->gmmio_base = p->start;
>                         break;
>
> The code you quoted is missing the "case PAT_GMMIO" and printk.
>
> thanks,
> grant