All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oh Eomji <eomji.oh@samsung.com>
Cc: alsa-devel@alsa-project.org,
	JaeHun Jung <jh0801.jung@samsung.com>,
	Leon Romanovsky <leon@kernel.org>,
	Pavel Skripkin <paskripkin@gmail.com>,
	open list <linux-kernel@vger.kernel.org>,
	Takashi Iwai <tiwai@suse.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/3] sound: usb: Add vendor's hooking interface
Date: Fri, 25 Mar 2022 19:47:01 +0100	[thread overview]
Message-ID: <4032ca01-0576-aed6-fb22-426842852b70@kernel.org> (raw)
In-Reply-To: <Yjwsh4N6dFKvWGav@kroah.com>

On 24/03/2022 09:32, Greg Kroah-Hartman wrote:
> On Thu, Mar 24, 2022 at 05:10:42PM +0900, Oh Eomji wrote:
>> In mobile, a co-processor can be used with USB audio to improve
>> power consumption.  To support this type of hardware, hooks need to
>> be added to the USB audio subsystem to be able to call into the
>> hardware when needed.
>> 
>> The main operation of the call-backs are: - Initialize the
>> co-processor by transmitting data when initializing. - Change the
>> co-processor setting value through the interface function. -
>> Configure sampling rate - pcm open/close - other housekeeping
>> 
>> Known issues: - This only supports one set of callback hooks,
>> meaning that this only works if there is one type of USB controller
>> in the system.  This should be changed to be a per-host-controller
>> interface instead of one global set of callbacks.
> 
> Sorry, but this limitation alone means that this is not going to be
> able to be accepted.  Almost all real systems have multiple USB
> controllers in the system and so, this will break in very bad ways on
> the majority of devices in the world.
> 
> Please fix this up and make this per-USB-controller, as was
> requested the last time this series was published.

This is a v2 (not v1) and Greg asked this already:
https://lore.kernel.org/all/YiW6ZqnINsOSyN+z@kroah.com/
That time, it was left without an answer.

Ignoring feedback and resending does not help in getting patches
mainlined. :(

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oh Eomji <eomji.oh@samsung.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	open list <linux-kernel@vger.kernel.org>,
	alsa-devel@alsa-project.org, Leon Romanovsky <leon@kernel.org>,
	Pavel Skripkin <paskripkin@gmail.com>,
	JaeHun Jung <jh0801.jung@samsung.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v1 1/3] sound: usb: Add vendor's hooking interface
Date: Fri, 25 Mar 2022 19:47:01 +0100	[thread overview]
Message-ID: <4032ca01-0576-aed6-fb22-426842852b70@kernel.org> (raw)
In-Reply-To: <Yjwsh4N6dFKvWGav@kroah.com>

On 24/03/2022 09:32, Greg Kroah-Hartman wrote:
> On Thu, Mar 24, 2022 at 05:10:42PM +0900, Oh Eomji wrote:
>> In mobile, a co-processor can be used with USB audio to improve
>> power consumption.  To support this type of hardware, hooks need to
>> be added to the USB audio subsystem to be able to call into the
>> hardware when needed.
>> 
>> The main operation of the call-backs are: - Initialize the
>> co-processor by transmitting data when initializing. - Change the
>> co-processor setting value through the interface function. -
>> Configure sampling rate - pcm open/close - other housekeeping
>> 
>> Known issues: - This only supports one set of callback hooks,
>> meaning that this only works if there is one type of USB controller
>> in the system.  This should be changed to be a per-host-controller
>> interface instead of one global set of callbacks.
> 
> Sorry, but this limitation alone means that this is not going to be
> able to be accepted.  Almost all real systems have multiple USB
> controllers in the system and so, this will break in very bad ways on
> the majority of devices in the world.
> 
> Please fix this up and make this per-USB-controller, as was
> requested the last time this series was published.

This is a v2 (not v1) and Greg asked this already:
https://lore.kernel.org/all/YiW6ZqnINsOSyN+z@kroah.com/
That time, it was left without an answer.

Ignoring feedback and resending does not help in getting patches
mainlined. :(

Best regards,
Krzysztof

  reply	other threads:[~2022-03-25 18:48 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220324081208epcas2p41916730b7e386f24e5548fac53e5bc41@epcas2p4.samsung.com>
2022-03-24  8:10 ` [PATCH v1 0/3] Exynos Usb Audio Offloading Support Oh Eomji
2022-03-24  8:10   ` Oh Eomji
2022-03-24  8:10   ` [PATCH v1 1/3] sound: usb: Add vendor's hooking interface Oh Eomji
2022-03-24  8:10     ` Oh Eomji
2022-03-24  8:32     ` Greg Kroah-Hartman
2022-03-24  8:32       ` Greg Kroah-Hartman
2022-03-25 18:47       ` Krzysztof Kozlowski [this message]
2022-03-25 18:47         ` Krzysztof Kozlowski
2022-03-24  8:33     ` Greg Kroah-Hartman
2022-03-24  8:33       ` Greg Kroah-Hartman
2022-03-25  6:44       ` Oh Eomji
2022-03-25  6:44         ` Oh Eomji
2022-03-25  6:51         ` Greg Kroah-Hartman
2022-03-25  6:51           ` Greg Kroah-Hartman
2022-03-25  8:01     ` Christoph Hellwig
2022-03-25  8:01       ` Christoph Hellwig
2022-03-24  8:10   ` [PATCH v1 2/3] sound: usb: Calling vendor's call-back function within usb audio operation Oh Eomji
2022-03-24  8:10     ` Oh Eomji
2022-03-24  8:34     ` Greg Kroah-Hartman
2022-03-24  8:34       ` Greg Kroah-Hartman
2022-03-25  7:13       ` Oh Eomji
2022-03-25  7:13         ` Oh Eomji
2022-03-25  7:33         ` Greg Kroah-Hartman
2022-03-25  7:33           ` Greg Kroah-Hartman
2022-03-24  8:10   ` [PATCH v1 3/3] sound: usb: Exynos usb audio offloading driver Oh Eomji
2022-03-24  8:10     ` Oh Eomji
2022-03-24  8:41     ` Greg Kroah-Hartman
2022-03-24  8:41       ` Greg Kroah-Hartman
2022-03-28  6:49       ` Oh Eomji
2022-03-28  6:49         ` Oh Eomji
2022-03-25 18:44     ` Krzysztof Kozlowski
2022-03-25 18:44       ` Krzysztof Kozlowski
2022-03-28  6:59       ` Oh Eomji
2022-03-28  6:59         ` Oh Eomji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4032ca01-0576-aed6-fb22-426842852b70@kernel.org \
    --to=krzk@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=eomji.oh@samsung.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jh0801.jung@samsung.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paskripkin@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.