* data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
@ 2004-02-19 12:40 Jens Benecke
2004-02-20 18:56 ` John Dalbec
2004-02-20 19:08 ` Chris Mason
0 siblings, 2 replies; 6+ messages in thread
From: Jens Benecke @ 2004-02-19 12:40 UTC (permalink / raw)
To: reiserfs-list
[-- Attachment #1: Type: text/plain, Size: 3034 bytes --]
Hi,
Chris' data-logging patches do not apply cleanly to 2.4.25, are they being
updated?
I think the fix for inode.c is not very hard but I don't dare to fiddle
around with file system code. ;)
Thank you!
server:linux-2.4.25-r> for X in ../*gz ; do zcat $X | patch -p1 ; done
patching file fs/reiserfs/inode.c
patching file fs/reiserfs/journal.c
patching file fs/buffer.c
Hunk #1 succeeded at 799 with fuzz 1 (offset 64 lines).
patching file fs/jbd/journal.c
patching file include/linux/fs.h
Hunk #1 succeeded at 266 (offset 3 lines).
patching file include/linux/jbd.h
Hunk #1 succeeded at 311 (offset 26 lines).
patching file fs/reiserfs/bitmap.c
patching file fs/reiserfs/journal.c
patching file fs/reiserfs/objectid.c
patching file fs/reiserfs/super.c
patching file fs/reiserfs/ibalance.c
patching file include/linux/reiserfs_fs_sb.h
patching file include/linux/reiserfs_fs.h
patching file fs/reiserfs/Makefile
patching file fs/reiserfs/tail_conversion.c
patching file fs/reiserfs/journal.c
patching file fs/reiserfs/stree.c
patching file fs/reiserfs/namei.c
patching file fs/reiserfs/super.c
patching file fs/reiserfs/file.c
patching file fs/reiserfs/procfs.c
patching file fs/reiserfs/fix_node.c
patching file fs/reiserfs/inode.c
patching file fs/reiserfs/ioctl.c
patching file fs/reiserfs/do_balan.c
patching file fs/buffer.c
Hunk #1 succeeded at 659 (offset 36 lines).
Hunk #2 succeeded at 1112 (offset 36 lines).
Hunk #3 succeeded at 1386 with fuzz 2 (offset 36 lines).
patching file kernel/ksyms.c
Hunk #1 succeeded at 175 with fuzz 2 (offset 3 lines).
patching file include/linux/fs.h
Hunk #1 succeeded at 1214 (offset 4 lines).
Hunk #2 succeeded at 1503 (offset 42 lines).
patching file include/linux/reiserfs_fs_i.h
patching file include/linux/reiserfs_fs_sb.h
patching file include/linux/reiserfs_fs.h
patching file fs/reiserfs/tail_conversion.c
patching file fs/reiserfs/bitmap.c
patching file fs/reiserfs/stree.c
patching file fs/reiserfs/namei.c
patching file fs/reiserfs/super.c
patching file fs/reiserfs/file.c
patching file fs/reiserfs/fix_node.c
patching file fs/reiserfs/inode.c
patching file fs/reiserfs/do_balan.c
patching file include/linux/reiserfs_fs.h
patching file fs/inode.c
Hunk #1 succeeded at 503 (offset 32 lines).
Hunk #2 succeeded at 522 (offset 32 lines).
Hunk #3 succeeded at 787 (offset 33 lines).
Hunk #4 FAILED at 821.
Hunk #5 succeeded at 1285 (offset 92 lines).
Hunk #6 succeeded at 1365 (offset 92 lines).
Hunk #7 succeeded at 1474 (offset 97 lines).
1 out of 7 hunks FAILED -- saving rejects to file fs/inode.c.rej
patching file mm/filemap.c
Hunk #1 succeeded at 3151 with fuzz 1 (offset 325 lines).
Hunk #2 succeeded at 3317 with fuzz 2 (offset 354 lines).
--
Jens Benecke (jens at spamfreemail.de)
http://www.hitchhikers.de - Europaweite kostenlose Mitfahrzentrale
http://www.spamfreemail.de - 100% saubere Postfächer - garantiert!
http://www.rb-hosting.de - PHP ab 9? - SSH ab 19? - günstiger Traffic
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: inode.c.rej --]
[-- Type: text/x-diff; name="inode.c.rej", Size: 1393 bytes --]
***************
*** 820,854 ****
spin_unlock(&inode_lock);
dispose_list(freeable);
/*
- * If we didn't freed enough clean inodes schedule
- * a sync of the dirty inodes, we cannot do it
- * from here or we're either synchronously dogslow
- * or we deadlock with oom.
*/
if (goal)
- schedule_task(&unused_inodes_flush_task);
}
int shrink_icache_memory(int priority, int gfp_mask)
{
int count = 0;
-
- /*
- * Nasty deadlock avoidance..
- *
- * We may hold various FS locks, and we don't
- * want to recurse into the FS that called us
- * in clear_inode() and friends..
- */
- if (!(gfp_mask & __GFP_FS))
- return 0;
-
count = inodes_stat.nr_unused / priority;
-
prune_icache(count);
- return kmem_cache_shrink(inode_cachep);
}
/*
--- 821,849 ----
spin_unlock(&inode_lock);
dispose_list(freeable);
+ kmem_cache_shrink(inode_cachep);
/*
+ * If we didn't freed enough clean inodes
+ * start a sync now
*/
if (goal)
+ try_to_sync_unused_inodes();
+ }
+
+ void prune_icache(int goal) {
+ atomic_add(goal, &kinoded_goal);
+ if (atomic_read(&kinoded_goal) > 16) {
+ wake_up_interruptible(&kinoded_wait);
+ }
}
int shrink_icache_memory(int priority, int gfp_mask)
{
int count = 0;
count = inodes_stat.nr_unused / priority;
prune_icache(count);
+ return 0;
}
/*
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
2004-02-19 12:40 data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25 Jens Benecke
@ 2004-02-20 18:56 ` John Dalbec
2004-02-20 19:08 ` Chris Mason
1 sibling, 0 replies; 6+ messages in thread
From: John Dalbec @ 2004-02-20 18:56 UTC (permalink / raw)
To: Jens Benecke; +Cc: reiserfs-list
Jens Benecke wrote:
> Hi,
>
> Chris' data-logging patches do not apply cleanly to 2.4.25, are they being
> updated?
Not by Chris; his time is devoted to data-logging for 2.6 kernels now.
>
> I think the fix for inode.c is not very hard but I don't dare to fiddle
> around with file system code. ;)
Maybe you should post the relevant section of inode.c from 2.4.25? Many eyes
and all that...
John
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
2004-02-19 12:40 data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25 Jens Benecke
2004-02-20 18:56 ` John Dalbec
@ 2004-02-20 19:08 ` Chris Mason
2004-02-23 13:29 ` Jens Benecke
1 sibling, 1 reply; 6+ messages in thread
From: Chris Mason @ 2004-02-20 19:08 UTC (permalink / raw)
To: Jens Benecke; +Cc: reiserfs-list
On Thu, 2004-02-19 at 07:40, Jens Benecke wrote:
> Hi,
>
> Chris' data-logging patches do not apply cleanly to 2.4.25, are they being
> updated?
>
> I think the fix for inode.c is not very hard but I don't dare to fiddle
> around with file system code. ;)
Ok, I'll rediff the data logging + quota against 2.4.25.
-chris
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
2004-02-20 19:08 ` Chris Mason
@ 2004-02-23 13:29 ` Jens Benecke
2004-02-23 13:48 ` Dieter Nützel
0 siblings, 1 reply; 6+ messages in thread
From: Jens Benecke @ 2004-02-23 13:29 UTC (permalink / raw)
To: reiserfs-list
Chris Mason wrote:
> On Thu, 2004-02-19 at 07:40, Jens Benecke wrote:
>> Hi,
>>
>> Chris' data-logging patches do not apply cleanly to 2.4.25, are they
>> being updated?
>>
>> I think the fix for inode.c is not very hard but I don't dare to fiddle
>> around with file system code. ;)
>
> Ok, I'll rediff the data logging + quota against 2.4.25.
Chris,
that would be great!
I have some software that depends on 2.4.x for the time being, I cannot
upgrade yet. (drbd for example)
Thank you!
--
Jens Benecke (jens at spamfreemail.de)
http://www.hitchhikers.de - Europaweite kostenlose Mitfahrzentrale
http://www.spamfreemail.de - 100% saubere Postfächer - garantiert!
http://www.rb-hosting.de - PHP ab 9? - SSH ab 19? - günstiger Traffic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
2004-02-23 13:29 ` Jens Benecke
@ 2004-02-23 13:48 ` Dieter Nützel
2004-02-23 14:12 ` Chris Mason
0 siblings, 1 reply; 6+ messages in thread
From: Dieter Nützel @ 2004-02-23 13:48 UTC (permalink / raw)
To: Chris Mason, Jens Benecke; +Cc: reiserfs-list
Am Montag, 23. Februar 2004 14:29 schrieb Jens Benecke:
> Chris Mason wrote:
> > On Thu, 2004-02-19 at 07:40, Jens Benecke wrote:
> >> Hi,
> >>
> >> Chris' data-logging patches do not apply cleanly to 2.4.25, are they
> >> being updated?
> >>
> >> I think the fix for inode.c is not very hard but I don't dare to fiddle
> >> around with file system code. ;)
> >
> > Ok, I'll rediff the data logging + quota against 2.4.25.
Have you missed this one, Jens?
updated data logging and quota for 2.4.25
http://marc.theaimsgroup.com/?l=reiserfs&m=107749109315488&w=2
Chris, what's happening to them?
Regards,
Dieter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25
2004-02-23 13:48 ` Dieter Nützel
@ 2004-02-23 14:12 ` Chris Mason
0 siblings, 0 replies; 6+ messages in thread
From: Chris Mason @ 2004-02-23 14:12 UTC (permalink / raw)
To: Dieter Nützel, johan; +Cc: Jens Benecke, reiserfs-list
[-- Attachment #1: Type: text/plain, Size: 823 bytes --]
On Mon, 2004-02-23 at 08:48, Dieter Nützel wrote:
> Am Montag, 23. Februar 2004 14:29 schrieb Jens Benecke:
> > Chris Mason wrote:
> > > On Thu, 2004-02-19 at 07:40, Jens Benecke wrote:
> > >> Hi,
> > >>
> > >> Chris' data-logging patches do not apply cleanly to 2.4.25, are they
> > >> being updated?
> > >>
> > >> I think the fix for inode.c is not very hard but I don't dare to fiddle
> > >> around with file system code. ;)
> > >
> > > Ok, I'll rediff the data logging + quota against 2.4.25.
>
> Have you missed this one, Jens?
>
> updated data logging and quota for 2.4.25
> http://marc.theaimsgroup.com/?l=reiserfs&m=107749109315488&w=2
There seems to be some ftp.suse.com problems, that patches haven't made
it over yet. The only one that changed was kinoded, I've attached it.
-chris
[-- Attachment #2: 07-kinode-10.diff.gz --]
[-- Type: application/x-gzip, Size: 1575 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-02-23 14:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-02-19 12:40 data-logging 2.4.23 patches: 1 reject in fs/inode.c in 2.4.25 Jens Benecke
2004-02-20 18:56 ` John Dalbec
2004-02-20 19:08 ` Chris Mason
2004-02-23 13:29 ` Jens Benecke
2004-02-23 13:48 ` Dieter Nützel
2004-02-23 14:12 ` Chris Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.