All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Correctly handle module aliases
@ 2016-01-21 16:13 Fabian Vogt
       [not found] ` <40374262.eB5p3XdtTH-Bm6d+KqpjsTpRLhIRNQA6g@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Fabian Vogt @ 2016-01-21 16:13 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org

Handle module aliases correctly to not generate unbootable
initrds with different kernel versions when modules were renamed
or replaced.

Signed-off-by: Fabian Vogt <fvogt-IBi9RG/b67k@public.gmane.org>
---

This is the case for mpt3sas -> mpt2sas migration in kernel 4.4,
which caused issues like https://bugzilla.opensuse.org/show_bug.cgi?id=962694

 dracut.sh | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/dracut.sh b/dracut.sh
index 98dbe0b..ae8772b 100755
--- a/dracut.sh
+++ b/dracut.sh
@@ -1195,6 +1195,27 @@ if [[ $hostonly ]]; then
     while read m rest || [ -n "$m" ]; do
         host_modules["$m"]=1
     done </proc/modules
+
+    # Explanation of the following section:
+    # Since kernel 4.4, mpt3sas is a complete replacement for mpt2sas.
+    # mpt3sas has an alias to mpt2sas now, but since mpt3sas isn't loaded
+    # when generating the initrd from kernel < 4.4, it's not included.
+    # The other direction has the same issue:
+    # When generating the initrd from kernel >= 4.4, mpt2sas isn't loaded,
+    # so it's not included.
+    # Both ways result in an unbootable initrd.
+
+    # also add aliases of loaded modules
+    for mod in "${!host_modules[@]}"; do
+        aliases=$(modinfo -F alias "$mod" 2>&1)
+        for alias in $aliases; do
+            host_modules["$alias"]=1
+        done
+        # mod might be an alias in the target kernel, find the real module
+        mod_filename=$(modinfo -k "$kernel" "$mod" -F filename)
+        [ $? -ne 0 ] && continue
+        host_modules["$(basename -s .ko "$mod_filename")"]=1
+    done
 fi
 
 unset m
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Correctly handle module aliases
       [not found] ` <40374262.eB5p3XdtTH-Bm6d+KqpjsTpRLhIRNQA6g@public.gmane.org>
@ 2016-01-21 17:02   ` Dracut GitHub Import Bot
  0 siblings, 0 replies; 2+ messages in thread
From: Dracut GitHub Import Bot @ 2016-01-21 17:02 UTC (permalink / raw)
  To: initramfs-u79uwXL29TY76Z2rM5mHXA

Patchset imported to github.
Pull request:
<https://github.com/haraldh/dracut/compare/master...dracut-mailing-devs:40374262.eB5p3XdtTH%40linux-lm3i.site>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-01-21 17:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-21 16:13 [PATCH] Correctly handle module aliases Fabian Vogt
     [not found] ` <40374262.eB5p3XdtTH-Bm6d+KqpjsTpRLhIRNQA6g@public.gmane.org>
2016-01-21 17:02   ` Dracut GitHub Import Bot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.