[ALSA] emu10k1 driver oops loading large soundfont 2.6.3

[ALSA] emu10k1 driver oops loading large soundfont 2.6.3

[Michael]

please CC: me on replies

In struct snd_emu10k1_memblk in include/sound/emu10k1.h first_page and 
last_page are defined as short.
                                                                                

Loading a soundfont that goes beyond 32767 pages causes an oops because 
{first|last}_page go negative in snd_emu10k1_sample_new 
(sound/pci/emu10k1/emu10k1_patch.c) as sfxload loads the font.

Changing {first|last}_page to int allows the soundfont to load and it 
appears to work fine.

-- 
Michael.

Re: [ALSA] emu10k1 driver oops loading large soundfont 2.6.3

[Willy Tarreau]

On Mon, Feb 23, 2004 at 05:23:08AM +0000, Michael wrote:
> please CC: me on replies
> 
> In struct snd_emu10k1_memblk in include/sound/emu10k1.h first_page and 
> last_page are defined as short.

Thanks a lot !

I've had this problem for about a year, making it impossible to load a
full fluidr3 sound font at once. I've searched for the cause of the problem,
but didn't find anything and concluded that it should have been a hardware
limitation, which in fact was not !

Great catch !

Cheers,
Willy