From: Brian King <brking@us.ibm.com>
To: linux-scsi@vger.kernel.org
Subject: [PATCH] Fix eh_abort race condition
Date: Wed, 25 Feb 2004 10:11:29 -0600 [thread overview]
Message-ID: <403CC931.8080309@us.ibm.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 193 bytes --]
The following patch fixes the race condition discussed here:
http://marc.theaimsgroup.com/?l=linux-scsi&m=107757213405773&w=2
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
[-- Attachment #2: patch-2.6.3-eh_abort.patch --]
[-- Type: text/plain, Size: 1786 bytes --]
The following patch fixes a race condition in abort processing. With this
patch, the mid-layer can now guarantee to LLDs that it will only call
eh_abort for ops which returned 0 in queuecommand and have not yet had
their ->done function called.
---
diff -puN drivers/scsi/scsi_error.c~eh_abort drivers/scsi/scsi_error.c
--- linux-2.6.3/drivers/scsi/scsi_error.c~eh_abort Wed Feb 25 09:54:52 2004
+++ linux-2.6.3-bjking1/drivers/scsi/scsi_error.c Wed Feb 25 09:54:52 2004
@@ -471,8 +471,9 @@ static int scsi_send_eh_cmnd(struct scsi
* we should treat them differently anyways.
*/
spin_lock_irqsave(scmd->device->host->host_lock, flags);
- if (scmd->device->host->hostt->eh_abort_handler)
- scmd->device->host->hostt->eh_abort_handler(scmd);
+ if (scmd->serial_number != 0)
+ if (scmd->device->host->hostt->eh_abort_handler)
+ scmd->device->host->hostt->eh_abort_handler(scmd);
spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
scmd->request->rq_status = RQ_SCSI_DONE;
@@ -687,17 +688,17 @@ static int scsi_try_to_abort_cmd(struct
if (!scmd->device->host->hostt->eh_abort_handler)
return rtn;
+ spin_lock_irqsave(scmd->device->host->host_lock, flags);
/*
* scsi_done was called just after the command timed out and before
* we had a chance to process it. (db)
*/
- if (scmd->serial_number == 0)
- return SUCCESS;
-
- scmd->owner = SCSI_OWNER_LOWLEVEL;
-
- spin_lock_irqsave(scmd->device->host->host_lock, flags);
- rtn = scmd->device->host->hostt->eh_abort_handler(scmd);
+ if (scmd->serial_number == 0) {
+ rtn = SUCCESS;
+ } else {
+ scmd->owner = SCSI_OWNER_LOWLEVEL;
+ rtn = scmd->device->host->hostt->eh_abort_handler(scmd);
+ }
spin_unlock_irqrestore(scmd->device->host->host_lock, flags);
return rtn;
_
next reply other threads:[~2004-02-25 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-25 16:11 Brian King [this message]
2004-02-25 17:55 ` [PATCH] Fix eh_abort race condition Mike Anderson
2004-02-25 21:10 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=403CC931.8080309@us.ibm.com \
--to=brking@us.ibm.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.