Re: [PATCH] Fix eh_abort race condition

[Brian King <brking@us.ibm.com>]

Mike Anderson wrote:
> Brian King [brking@us.ibm.com] wrote:
> 
>>The following patch fixes a race condition in abort processing. With this
>>patch, the mid-layer can now guarantee to LLDs that it will only call
>>eh_abort for ops which returned 0 in queuecommand and have not yet had 
>>their ->done function called.
> 
> 
> 
> How does this address the race of scsi_times_out has fired and the LLD
> calls scsi_done. scsi_done will return prior to setting the serial
> number to 0 if the timer has fired. The LLDD will believe scsi_done
> added the command to the scsi_done_q, but it did not.

It doesn't;) I missed that... Is the fix as simple as changing
scsi_times_out to zero the serial_number before calling scsi_delete_timer,
or am I missing something?



-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center