All of lore.kernel.org
 help / color / mirror / Atom feed
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/6] ARM: rockchip: add debug uart used by rk3288
Date: Wed, 16 Jul 2014 11:11:22 +0200	[thread overview]
Message-ID: <4054962.m70Hhy4CVc@diego> (raw)
In-Reply-To: <CAD=FV=W3aWeT3RP5_g9r8kV8ToeHfyn57JY-py2zGVW9DF_7RQ@mail.gmail.com>

Am Dienstag, 15. Juli 2014, 21:13:10 schrieb Doug Anderson:
> Heiko,
> 
> On Tue, Jul 15, 2014 at 4:00 PM, Heiko St?bner <heiko@sntech.de> wrote:
> > The uarts on rk3288 are still compatible with the dw_8250, but located
> > at a different position and need DEBUG_UART_8250_WORD enabled.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > 
> >  arch/arm/Kconfig.debug | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 8f90595..f68def0 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -613,6 +613,14 @@ choice
> > 
> >                   Say Y here if you want kernel low-level debugging
> >                   support
> >                   on Rockchip based platforms.
> > 
> > +       config DEBUG_RK32_UART2
> 
> It's slightly confusing that you didn't rename the old "DEBUG_RK3X_UART2".

My problem is, to what :-) ... DEBUG_RK30_UART2 ?

RK30xx and RK31xx share these, but I guess at least the description should be 
adapted.


> 
> Other than that:
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>
> Tested-by: Doug Anderson <dianders@chromium.org>

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
	Eddie Cai <eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>
Subject: Re: [PATCH 2/6] ARM: rockchip: add debug uart used by rk3288
Date: Wed, 16 Jul 2014 11:11:22 +0200	[thread overview]
Message-ID: <4054962.m70Hhy4CVc@diego> (raw)
In-Reply-To: <CAD=FV=W3aWeT3RP5_g9r8kV8ToeHfyn57JY-py2zGVW9DF_7RQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Am Dienstag, 15. Juli 2014, 21:13:10 schrieb Doug Anderson:
> Heiko,
> 
> On Tue, Jul 15, 2014 at 4:00 PM, Heiko Stübner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> wrote:
> > The uarts on rk3288 are still compatible with the dw_8250, but located
> > at a different position and need DEBUG_UART_8250_WORD enabled.
> > 
> > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > ---
> > 
> >  arch/arm/Kconfig.debug | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
> > index 8f90595..f68def0 100644
> > --- a/arch/arm/Kconfig.debug
> > +++ b/arch/arm/Kconfig.debug
> > @@ -613,6 +613,14 @@ choice
> > 
> >                   Say Y here if you want kernel low-level debugging
> >                   support
> >                   on Rockchip based platforms.
> > 
> > +       config DEBUG_RK32_UART2
> 
> It's slightly confusing that you didn't rename the old "DEBUG_RK3X_UART2".

My problem is, to what :-) ... DEBUG_RK30_UART2 ?

RK30xx and RK31xx share these, but I guess at least the description should be 
adapted.


> 
> Other than that:
> 
> Reviewed-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Tested-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2014-07-16  9:11 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-15 22:58 [PATCH 0/6] ARM: rockchip: add initial support for rk3288 Heiko Stübner
2014-07-15 22:58 ` Heiko Stübner
2014-07-15 22:59 ` [PATCH 1/6] dt-bindings: arm: add arm, cortex-a12 cpu compatible property Heiko Stübner
2014-07-15 22:59   ` [PATCH 1/6] dt-bindings: arm: add arm,cortex-a12 " Heiko Stübner
2014-07-16  0:56   ` Olof Johansson
2014-07-16  0:56     ` Olof Johansson
2014-07-16  9:03     ` Mark Rutland
2014-07-16  9:03       ` Mark Rutland
2014-07-15 23:00 ` [PATCH 2/6] ARM: rockchip: add debug uart used by rk3288 Heiko Stübner
2014-07-15 23:00   ` Heiko Stübner
2014-07-16  4:13   ` Doug Anderson
2014-07-16  4:13     ` Doug Anderson
2014-07-16  9:11     ` Heiko Stübner [this message]
2014-07-16  9:11       ` Heiko Stübner
2014-07-16 15:09       ` Doug Anderson
2014-07-16 15:09         ` Doug Anderson
2014-07-15 23:01 ` [PATCH 3/6] ARM: Kconfig: set default gpio number for rockchip SoCs Heiko Stübner
2014-07-15 23:01   ` Heiko Stübner
2014-07-16  4:41   ` Doug Anderson
2014-07-16  4:41     ` Doug Anderson
2014-07-15 23:01 ` [PATCH 4/6] ARM: rockchip: enable support for RK3288 SoCs Heiko Stübner
2014-07-15 23:01   ` Heiko Stübner
2014-07-16 19:57   ` Doug Anderson
2014-07-16 19:57     ` Doug Anderson
2014-07-16 20:22     ` Heiko Stübner
2014-07-16 20:22       ` Heiko Stübner
2014-07-17 10:20     ` Will Deacon
2014-07-17 10:20       ` Will Deacon
2014-07-15 23:02 ` [PATCH 5/6] ARM: dts: rockchip: add core rk3288 dtsi Heiko Stübner
2014-07-15 23:02   ` Heiko Stübner
2014-07-16  0:02   ` Doug Anderson
2014-07-16  0:02     ` Doug Anderson
2014-07-16  0:55   ` Olof Johansson
2014-07-16  0:55     ` Olof Johansson
2014-07-16 20:04   ` Doug Anderson
2014-07-16 20:04     ` Doug Anderson
2014-07-15 23:02 ` [PATCH 6/6] ARM: dts: add rk3288 evaluation board Heiko Stübner
2014-07-15 23:02   ` Heiko Stübner
2014-07-16  1:00   ` Olof Johansson
2014-07-16  1:00     ` Olof Johansson
2014-07-16 20:02   ` Doug Anderson
2014-07-16 20:02     ` Doug Anderson
2014-07-16 21:22     ` Heiko Stübner
2014-07-16 21:22       ` Heiko Stübner
2014-07-17 10:18 ` [PATCH 0/6] ARM: rockchip: add initial support for rk3288 Will Deacon
2014-07-17 10:18   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4054962.m70Hhy4CVc@diego \
    --to=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.