From: Heiko Stuebner <heiko@sntech.de>
To: Gray Huang <gray.huang@wesion.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
nick@khadas.com, Gray Huang <gray.huang@wesion.com>
Subject: Re: [PATCH 2/6] arm64: dts: rockchip: Add AP6275P wireless support for Khadas Edge 2L
Date: Mon, 27 Apr 2026 14:25:51 +0200 [thread overview]
Message-ID: <4059489.Mh6RI2rZIc@phil> (raw)
In-Reply-To: <20260325054614.1497147-3-gray.huang@wesion.com>
Am Mittwoch, 25. März 2026, 06:46:10 Mitteleuropäische Sommerzeit schrieb Gray Huang:
> The Khadas Edge 2L board uses the Ampak AP6275P (BCM43752) PCIe
> Wi-Fi 6 module.
>
> Enable the pcie0 controller and add the Wi-Fi module as its child
> node. Additionally, enable the HYM8563 RTC to provide the 32.768kHz
> LPO clock required by the Wi-Fi module, along with the necessary
> CombPHY and fixed regulator.
>
> Signed-off-by: Gray Huang <gray.huang@wesion.com>
Please make this 2 patches:
- add the rtc
- add the wifi using the rtc
> ---
> .../dts/rockchip/rk3576-khadas-edge-2l.dts | 71 ++++++++++++++++++-
> 1 file changed, 70 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts b/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> index 5781deae00d9..09cb0f0d6dcf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> @@ -47,7 +47,19 @@ vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 {
> vin-supply = <&vcc_sys>;
> };
>
> -
> + vcc_wifi_reg_on: regulator-wifi-reg-on {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&wifi_reg_on>;
> + pinctrl-names = "default";
> + regulator-name = "wifi_reg_on";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vcc_1v8_s3>;
> + };
> };
>
> &cpu_l0 {
> @@ -431,6 +443,63 @@ regulator-state-mem {
> };
> };
>
> +&combphy0_ps {
> + status = "okay";
> +};
also please sort also phandles alphabetically, i.e. pcie2 between
c-something and i2c is the wrong place :-)
Heiko
> +
> +&pcie0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie0_rst>;
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Gray Huang <gray.huang@wesion.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
nick@khadas.com, Gray Huang <gray.huang@wesion.com>
Subject: Re: [PATCH 2/6] arm64: dts: rockchip: Add AP6275P wireless support for Khadas Edge 2L
Date: Mon, 27 Apr 2026 14:25:51 +0200 [thread overview]
Message-ID: <4059489.Mh6RI2rZIc@phil> (raw)
In-Reply-To: <20260325054614.1497147-3-gray.huang@wesion.com>
Am Mittwoch, 25. März 2026, 06:46:10 Mitteleuropäische Sommerzeit schrieb Gray Huang:
> The Khadas Edge 2L board uses the Ampak AP6275P (BCM43752) PCIe
> Wi-Fi 6 module.
>
> Enable the pcie0 controller and add the Wi-Fi module as its child
> node. Additionally, enable the HYM8563 RTC to provide the 32.768kHz
> LPO clock required by the Wi-Fi module, along with the necessary
> CombPHY and fixed regulator.
>
> Signed-off-by: Gray Huang <gray.huang@wesion.com>
Please make this 2 patches:
- add the rtc
- add the wifi using the rtc
> ---
> .../dts/rockchip/rk3576-khadas-edge-2l.dts | 71 ++++++++++++++++++-
> 1 file changed, 70 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts b/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> index 5781deae00d9..09cb0f0d6dcf 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3576-khadas-edge-2l.dts
> @@ -47,7 +47,19 @@ vcc_2v0_pldo_s3: regulator-vcc-2v0-pldo-s3 {
> vin-supply = <&vcc_sys>;
> };
>
> -
> + vcc_wifi_reg_on: regulator-wifi-reg-on {
> + compatible = "regulator-fixed";
> + enable-active-high;
> + gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&wifi_reg_on>;
> + pinctrl-names = "default";
> + regulator-name = "wifi_reg_on";
> + regulator-always-on;
> + regulator-boot-on;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vcc_1v8_s3>;
> + };
> };
>
> &cpu_l0 {
> @@ -431,6 +443,63 @@ regulator-state-mem {
> };
> };
>
> +&combphy0_ps {
> + status = "okay";
> +};
also please sort also phandles alphabetically, i.e. pcie2 between
c-something and i2c is the wrong place :-)
Heiko
> +
> +&pcie0 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pcie0_rst>;
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2026-04-27 12:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 5:46 [PATCH 0/6] arm64: dts: rockchip: Add peripheral support for Khadas Edge 2L Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-03-25 5:46 ` [PATCH 1/6] arm64: dts: rockchip: Add PMIC " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-03-25 5:46 ` [PATCH 2/6] arm64: dts: rockchip: Add AP6275P wireless " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-04-27 12:25 ` Heiko Stuebner [this message]
2026-04-27 12:25 ` Heiko Stuebner
2026-03-25 5:46 ` [PATCH 3/6] arm64: dts: rockchip: Enable GPU " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-03-25 5:46 ` [PATCH 4/6] arm64: dts: rockchip: Add HDMI and VOP support " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-03-25 5:46 ` [PATCH 5/6] arm64: dts: rockchip: Enable USB " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-04-27 12:27 ` Heiko Stuebner
2026-04-27 12:27 ` Heiko Stuebner
2026-04-29 6:49 ` Gray Huang
2026-04-29 6:49 ` Gray Huang
2026-03-25 5:46 ` [PATCH 6/6] arm64: dts: rockchip: Add Bluetooth support " Gray Huang
2026-03-25 5:46 ` Gray Huang
2026-04-27 12:27 ` Heiko Stuebner
2026-04-27 12:27 ` Heiko Stuebner
2026-04-29 6:51 ` Gray Huang
2026-04-29 6:51 ` Gray Huang
2026-04-27 12:23 ` (subset) [PATCH 0/6] arm64: dts: rockchip: Add peripheral " Heiko Stuebner
2026-04-27 12:23 ` Heiko Stuebner
-- strict thread matches above, loose matches on Subject: below --
2026-03-28 21:50 [PATCH 2/6] arm64: dts: rockchip: Add AP6275P wireless " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4059489.Mh6RI2rZIc@phil \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gray.huang@wesion.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=nick@khadas.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.