* reiserfsprogs: lib/misc.c: why die() aborts? @ 2004-03-20 16:18 Domenico Andreoli 2004-03-22 12:49 ` Vladimir Saveliev 0 siblings, 1 reply; 6+ messages in thread From: Domenico Andreoli @ 2004-03-20 16:18 UTC (permalink / raw) To: reiserfs-list hi all, in trying to figure out what is the unpack program in reiserfsprogs and if it supposed to be distributed in the debian package, i came to the function die() in lib/misc.c. i'm seeing it regularly aborts the execution instead of using the usual exit(EXIT_FAILURE). shouldn't it be more polite or it is not for public use? what is unpack supposed to do? cheers domenico -----[ Domenico Andreoli, aka cavok --[ http://filibusta.crema.unimi.it/~cavok/gpgkey.asc ---[ 3A0F 2F80 F79C 678A 8936 4FEE 0677 9033 A20E BC50 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: reiserfsprogs: lib/misc.c: why die() aborts? 2004-03-20 16:18 reiserfsprogs: lib/misc.c: why die() aborts? Domenico Andreoli @ 2004-03-22 12:49 ` Vladimir Saveliev 2004-03-22 13:26 ` Chris Mason 0 siblings, 1 reply; 6+ messages in thread From: Vladimir Saveliev @ 2004-03-22 12:49 UTC (permalink / raw) To: Domenico Andreoli; +Cc: reiserfs-list Hi On Sat, 2004-03-20 at 19:18, Domenico Andreoli wrote: > hi all, > > in trying to figure out what is the unpack program in reiserfsprogs > and if it supposed to be distributed in the debian package, No, it should not be distributed > i came to > the function die() in lib/misc.c. > > i'm seeing it regularly aborts the execution instead of using the > usual exit(EXIT_FAILURE). shouldn't it be more polite or it is not for > public use? > > what is unpack supposed to do? > It is used for reiserfsprogs debugging > cheers > domenico > > -----[ Domenico Andreoli, aka cavok > --[ http://filibusta.crema.unimi.it/~cavok/gpgkey.asc > ---[ 3A0F 2F80 F79C 678A 8936 4FEE 0677 9033 A20E BC50 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: reiserfsprogs: lib/misc.c: why die() aborts? 2004-03-22 12:49 ` Vladimir Saveliev @ 2004-03-22 13:26 ` Chris Mason 2004-03-22 13:45 ` Vladimir Saveliev 0 siblings, 1 reply; 6+ messages in thread From: Chris Mason @ 2004-03-22 13:26 UTC (permalink / raw) To: Vladimir Saveliev; +Cc: Domenico Andreoli, reiserfs-list On Mon, 2004-03-22 at 07:49, Vladimir Saveliev wrote: > Hi > > On Sat, 2004-03-20 at 19:18, Domenico Andreoli wrote: > > hi all, > > > > in trying to figure out what is the unpack program in reiserfsprogs > > and if it supposed to be distributed in the debian package, > > No, it should not be distributed > Hmmm, I disagree. Normal users can use debugreiserfs -p and unpack to do test rebuilds on copies of broken filesystems when they are rebuilding critical data. -chris ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: reiserfsprogs: lib/misc.c: why die() aborts? 2004-03-22 13:26 ` Chris Mason @ 2004-03-22 13:45 ` Vladimir Saveliev 2004-03-22 13:57 ` Hans Reiser 2004-03-22 15:24 ` Vitaly Fertman 0 siblings, 2 replies; 6+ messages in thread From: Vladimir Saveliev @ 2004-03-22 13:45 UTC (permalink / raw) To: Chris Mason; +Cc: Domenico Andreoli, reiserfs-list Hello On Mon, 2004-03-22 at 16:26, Chris Mason wrote: > On Mon, 2004-03-22 at 07:49, Vladimir Saveliev wrote: > > Hi > > > > On Sat, 2004-03-20 at 19:18, Domenico Andreoli wrote: > > > hi all, > > > > > > in trying to figure out what is the unpack program in reiserfsprogs > > > and if it supposed to be distributed in the debian package, > > > > No, it should not be distributed > > > Hmmm, I disagree. Normal users can use debugreiserfs -p and unpack to > do test rebuilds on copies of broken filesystems when they are > rebuilding critical data. > Ok, but then we should rename it to better name. reiserfs_unpack, for example > -chris > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: reiserfsprogs: lib/misc.c: why die() aborts? 2004-03-22 13:45 ` Vladimir Saveliev @ 2004-03-22 13:57 ` Hans Reiser 2004-03-22 15:24 ` Vitaly Fertman 1 sibling, 0 replies; 6+ messages in thread From: Hans Reiser @ 2004-03-22 13:57 UTC (permalink / raw) To: Vladimir Saveliev; +Cc: Chris Mason, Domenico Andreoli, reiserfs-list Vladimir Saveliev wrote: >Hello > >On Mon, 2004-03-22 at 16:26, Chris Mason wrote: > > >>On Mon, 2004-03-22 at 07:49, Vladimir Saveliev wrote: >> >> >>>Hi >>> >>>On Sat, 2004-03-20 at 19:18, Domenico Andreoli wrote: >>> >>> >>>>hi all, >>>> >>>>in trying to figure out what is the unpack program in reiserfsprogs >>>>and if it supposed to be distributed in the debian package, >>>> >>>> >>>No, it should not be distributed >>> >>> >>> >>Hmmm, I disagree. Normal users can use debugreiserfs -p and unpack to >>do test rebuilds on copies of broken filesystems when they are >>rebuilding critical data. >> >> >> > >Ok, but then we should rename it to better name. reiserfs_unpack, for >example > > or reiserfs_unpack_metadata_bundle > > >>-chris >> >> >> >> >> > > > > > -- Hans ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: reiserfsprogs: lib/misc.c: why die() aborts? 2004-03-22 13:45 ` Vladimir Saveliev 2004-03-22 13:57 ` Hans Reiser @ 2004-03-22 15:24 ` Vitaly Fertman 1 sibling, 0 replies; 6+ messages in thread From: Vitaly Fertman @ 2004-03-22 15:24 UTC (permalink / raw) To: Vladimir Saveliev, Chris Mason; +Cc: Domenico Andreoli, reiserfs-list On Monday 22 March 2004 16:45, Vladimir Saveliev wrote: > Hello > > On Mon, 2004-03-22 at 16:26, Chris Mason wrote: > > On Mon, 2004-03-22 at 07:49, Vladimir Saveliev wrote: > > > Hi > > > > > > On Sat, 2004-03-20 at 19:18, Domenico Andreoli wrote: > > > > hi all, > > > > > > > > in trying to figure out what is the unpack program in reiserfsprogs > > > > and if it supposed to be distributed in the debian package, > > > > > > No, it should not be distributed > > > > Hmmm, I disagree. Normal users can use debugreiserfs -p and unpack to > > do test rebuilds on copies of broken filesystems when they are > > rebuilding critical data. > > Ok, but then we should rename it to better name. reiserfs_unpack, for > example ok, I will add the option 'unpack' in debugreiserfs instead of the unpack program. -- Thanks, Vitaly Fertman ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-03-22 15:24 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2004-03-20 16:18 reiserfsprogs: lib/misc.c: why die() aborts? Domenico Andreoli 2004-03-22 12:49 ` Vladimir Saveliev 2004-03-22 13:26 ` Chris Mason 2004-03-22 13:45 ` Vladimir Saveliev 2004-03-22 13:57 ` Hans Reiser 2004-03-22 15:24 ` Vitaly Fertman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.