a lot of different cards and controls

a lot of different cards and controls

[Giuliano Pochini]

My driver is almost complete and I'm working to make it acceptable for
inclusion in alsa-driver. It drives 8 different cards and it raises some
problems. The main file is echoaudio.c and is contains all the control
interfaces of all cards. It registers only the controls a card has at
runtime, so there is some useless bloat for some cards. It's not very much
because the lowlevel functions are defined in <card>Dsp.c and they are just
empty functions if the card hasn't that feature. I wonder if this is ok.
Otherwise I could split echoaudio.c into smaller peices and create several
echoaudio_<card>.c files that contain something like this:

#include "mixer_ctl.c"
#include "inputclock_ctl.c"
...
#include "echoaudio_main.c"

So it compiles only the parts that are really needed, at the cost of having
a lot more files and a bit less clear structure. What is the preferred
method ?



--
Giuliano.



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click

Re: a lot of different cards and controls

[Apostolos Dimitromanolakis]

I believe better structure should be the way to go. And since you're the 
one writing the drivers it is better if you follow the way you find it 
more reasonable and better for other people to understand.


Giuliano Pochini wrote:

>My driver is almost complete and I'm working to make it acceptable for
>inclusion in alsa-driver. It drives 8 different cards and it raises some
>problems. The main file is echoaudio.c and is contains all the control
>interfaces of all cards. It registers only the controls a card has at
>runtime, so there is some useless bloat for some cards. It's not very much
>because the lowlevel functions are defined in <card>Dsp.c and they are just
>empty functions if the card hasn't that feature. I wonder if this is ok.
>Otherwise I could split echoaudio.c into smaller peices and create several
>echoaudio_<card>.c files that contain something like this:
>
>#include "mixer_ctl.c"
>#include "inputclock_ctl.c"
>...
>#include "echoaudio_main.c"
>
>So it compiles only the parts that are really needed, at the cost of having
>a lot more files and a bit less clear structure. What is the preferred
>method ?
>
>
>
>--
>Giuliano.
>
>
>
>-------------------------------------------------------
>This SF.Net email is sponsored by: IBM Linux Tutorials
>Free Linux tutorial presented by Daniel Robbins, President and CEO of
>GenToo technologies. Learn everything from fundamentals to system
>administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
>_______________________________________________
>Alsa-devel mailing list
>Alsa-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/alsa-devel
>
>
>  
>



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click