From: Greg Aumann <Greg_Aumann@sil.org>
To: kernel-janitors@vger.kernel.org
Subject: [Kernel-janitors] (no subject)
Date: Thu, 08 Apr 2004 13:30:06 +0000 [thread overview]
Message-ID: <407553DE.1070907@sil.org> (raw)
In-Reply-To: <20040311044154.9A05E1D71A2@ws3-3.us4.outblaze.com>
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
Hi,
this is my first attempt at a kernel patch. It's pretty trivial, but
hey I have to start somewhere :-)! It updates one error message and one
comment to reflect someone else's removal/replacement of check_region.
It compiles ok but I don't have one of these devices so I can't do any
other testing.
The patch is against 2.6.5.
Comments are welcome.
Greg
[-- Attachment #2: comio90_check_region.patch --]
[-- Type: text/x-patch, Size: 903 bytes --]
diff -x tags -Naur linux-2.6.5/drivers/net/arcnet/com90io.c linux-2.6.5-kj/drivers/net/arcnet/com90io.c
--- linux-2.6.5/drivers/net/arcnet/com90io.c 2004-04-04 11:36:55.000000000 +0800
+++ linux-2.6.5-kj/drivers/net/arcnet/com90io.c 2004-04-08 20:22:43.000000000 +0800
@@ -160,7 +160,7 @@
return -ENODEV;
}
if (!request_region(ioaddr, ARCNET_TOTAL_SIZE, "com90io probe")) {
- BUGMSG(D_INIT_REASONS, "IO check_region %x-%x failed.\n",
+ BUGMSG(D_INIT_REASONS, "IO request_region %x-%x failed.\n",
ioaddr, ioaddr + ARCNET_TOTAL_SIZE - 1);
return -ENXIO;
}
@@ -242,7 +242,7 @@
BUGMSG(D_NORMAL, "Can't get IRQ %d!\n", dev->irq);
return -ENODEV;
}
- /* Reserve the I/O region - guaranteed to work by check_region */
+ /* Reserve the I/O region */
if (!request_region(dev->base_addr, ARCNET_TOTAL_SIZE, "arcnet (COM90xx-IO)")) {
free_irq(dev->irq, dev);
return -EBUSY;
[-- Attachment #3: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-04-08 13:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-11 4:41 [Kernel-janitors] (no subject) dan carpenter
2004-04-08 13:30 ` Greg Aumann [this message]
2004-04-08 21:03 ` Don Koch
2004-04-20 21:03 ` Randy.Dunlap
2004-05-19 15:33 ` Brendan Burns
2004-09-16 23:34 ` java solaris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407553DE.1070907@sil.org \
--to=greg_aumann@sil.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.