[Kernel-janitors] (no subject)

[Kernel-janitors] (no subject)

[dan carpenter]

On Wednesday 10 March 2004 08:12 pm, Badai Aqrandista wrote:
> How about memmove / memcpy problem, but where should I start? Any drivers?
>

It doesn't matter where you start.  Just do a small patch against one file at 
first.  Send that to the list.  We'll help you make sure the patch is in the 
correct format etc.  It's good practice.

regards,
dan carpenter
-- 
___________________________________________________________
Sign-up for Ads Free at Mail.com
http://promo.mail.com/adsfreejump.htm

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] (no subject)

[Greg Aumann]

[-- Attachment #1: Type: text/plain, Size: 368 bytes --]

Hi,
    this is my first attempt at a kernel patch. It's pretty trivial, but 
hey I have to start somewhere :-)! It updates one error message and one 
comment to reflect someone else's removal/replacement of check_region. 
It compiles ok but I don't have one of these devices so I can't do any 
other testing.

The patch is against 2.6.5.

Comments are welcome.

Greg

[-- Attachment #2: comio90_check_region.patch --]
[-- Type: text/x-patch, Size: 903 bytes --]

diff -x tags -Naur linux-2.6.5/drivers/net/arcnet/com90io.c linux-2.6.5-kj/drivers/net/arcnet/com90io.c
--- linux-2.6.5/drivers/net/arcnet/com90io.c	2004-04-04 11:36:55.000000000 +0800
+++ linux-2.6.5-kj/drivers/net/arcnet/com90io.c	2004-04-08 20:22:43.000000000 +0800
@@ -160,7 +160,7 @@
 		return -ENODEV;
 	}
 	if (!request_region(ioaddr, ARCNET_TOTAL_SIZE, "com90io probe")) {
-		BUGMSG(D_INIT_REASONS, "IO check_region %x-%x failed.\n",
+		BUGMSG(D_INIT_REASONS, "IO request_region %x-%x failed.\n",
 		       ioaddr, ioaddr + ARCNET_TOTAL_SIZE - 1);
 		return -ENXIO;
 	}
@@ -242,7 +242,7 @@
 		BUGMSG(D_NORMAL, "Can't get IRQ %d!\n", dev->irq);
 		return -ENODEV;
 	}
-	/* Reserve the I/O region - guaranteed to work by check_region */
+	/* Reserve the I/O region */
 	if (!request_region(dev->base_addr, ARCNET_TOTAL_SIZE, "arcnet (COM90xx-IO)")) {
 		free_irq(dev->irq, dev);
 		return -EBUSY;

[-- Attachment #3: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] (no subject)

[Don Koch]

[-- Attachment #1: Type: text/plain, Size: 886 bytes --]

There's an instance in kj.pl (and kj-devel.pl) of a missing
argument to a call to check_pci_enable_device().  Patch follows.

-- 
Don Koch
http://www.krl.com/

--- kj.pl~	2004-04-08 15:41:08.000000000 -0400
+++ kj.pl	2004-04-08 16:48:13.000000000 -0400
@@ -149,7 +149,7 @@
 
 		if ($line=~/pdev-\>resource/) {
 			print "Make sure pci_enable_device --before-- reading resource\n";
-			check_pci_enable_device($linenr);
+			check_pci_enable_device($linenr, $filename);
 			print "$filename:$linenr:$line\n\n";
 		}
 
--- kj-devel.pl~	2004-04-08 15:41:17.000000000 -0400
+++ kj-devel.pl	2004-04-08 16:48:56.000000000 -0400
@@ -146,7 +146,7 @@
 
 		if ($line=~/pdev-\>resource/) {
 			print "Make sure pci_enable_device --before-- reading resource\n";
-			check_pci_enable_device($linenr);
+			check_pci_enable_device($linenr, $filename);
 			print "$filename:$linenr:$line\n\n";
 		}
 



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [Kernel-janitors] (no subject)

[Randy.Dunlap]

[-- Attachment #1: Type: text/plain, Size: 1183 bytes --]

On Thu, 08 Apr 2004 17:03:06 -0400 Don Koch wrote:

| There's an instance in kj.pl (and kj-devel.pl) of a missing
| argument to a call to check_pci_enable_device().  Patch follows.
| 
| -- 
| 
| --- kj.pl~	2004-04-08 15:41:08.000000000 -0400
| +++ kj.pl	2004-04-08 16:48:13.000000000 -0400
| @@ -149,7 +149,7 @@
|  
|  		if ($line=~/pdev-\>resource/) {
|  			print "Make sure pci_enable_device --before-- reading resource\n";
| -			check_pci_enable_device($linenr);
| +			check_pci_enable_device($linenr, $filename);
|  			print "$filename:$linenr:$line\n\n";
|  		}
|  
| --- kj-devel.pl~	2004-04-08 15:41:17.000000000 -0400
| +++ kj-devel.pl	2004-04-08 16:48:56.000000000 -0400
| @@ -146,7 +146,7 @@
|  
|  		if ($line=~/pdev-\>resource/) {
|  			print "Make sure pci_enable_device --before-- reading resource\n";
| -			check_pci_enable_device($linenr);
| +			check_pci_enable_device($linenr, $filename);
|  			print "$filename:$linenr:$line\n\n";
|  		}

Applied, thanks.

If the cron job is working correctly, these scripts and other KJ
files will be copied to the web page interface automatically.
I'll have to check on it to see that it happens, or else.... fix it.

--
~Randy

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] (no subject)

[Brendan Burns]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1 bytes --]



[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

[Kernel-janitors] (no subject)

[java solaris]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

 
 

_________________________________________________________
Do You Yahoo!?
150万曲MP3疯狂搜，带您闯入音乐殿堂
http://music.yisou.com/
美女明星应有尽有，搜遍美图、艳图和酷图
http://image.yisou.com
1G就是1000兆，雅虎电邮自助扩容！
http://cn.rd.yahoo.com/mail_cn/tag/1g/*http://cn.mail.yahoo.com/event/mail_1g/

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors