All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: Friedrich Lobenstock <fl@fl.priv.at>,
	netfilter-devel@lists.netfilter.org
Subject: Re: latest pom: base/connlimit breaks kernel 2.4.25 compile (+possible fix)
Date: Sat, 10 Apr 2004 18:52:28 +0200	[thread overview]
Message-ID: <4078264C.5000909@eurodev.net> (raw)
In-Reply-To: 40780CAD.6080305@fl.priv.at

Hi Friedrich,

Friedrich Lobenstock wrote:

>-	/* NULL if ip_conntrack not a module */
>-	if (ip_conntrack_module)
>-		__MOD_INC_USE_COUNT(ip_conntrack_module);
>+	/* NULL if ip_connlimit not a module */
>+	if (ip_connlimit_module)
>+		__MOD_INC_USE_COUNT(ip_connlimit_module);
> 	return ipt_register_match(&connlimit_match);
> }
>
>  
>
AFAIK, the use of __MOD_INC_USE_COUNT is deprecated, actually I remember 
that someone posted to the maillist a related issue and Harald finally 
decided to remove them. If I'm missing anything, please let me know.

So I think that you could remove them, you could also post a patch to 
update the current match available in pom-ng :-).

regards,
Pablo

  reply	other threads:[~2004-04-10 16:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-10 15:03 latest pom: base/connlimit breaks kernel 2.4.25 compile (+possible fix) Friedrich Lobenstock
2004-04-10 16:52 ` Pablo Neira [this message]
2004-04-10 19:17   ` Friedrich Lobenstock
2004-04-10 23:58     ` Henrik Nordstrom
2004-04-11  0:04       ` Friedrich Lobenstock
2004-04-11 10:39         ` Henrik Nordstrom
2004-04-11 11:17           ` Friedrich Lobenstock
2004-04-11 20:47             ` Henrik Nordstrom
2004-04-11 21:00               ` Friedrich Lobenstock
2004-04-12  2:16                 ` Henrik Nordstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4078264C.5000909@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=fl@fl.priv.at \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.