Re: latest pom: base/connlimit breaks kernel 2.4.25 compile (+possible fix)

[Friedrich Lobenstock <fl@fl.priv.at>]

Hi Pablo!

Pablo Neira wrote on 10.04.2004 18:52 MET:
> Friedrich Lobenstock wrote:
> 
>> -    /* NULL if ip_conntrack not a module */
>> -    if (ip_conntrack_module)
>> -        __MOD_INC_USE_COUNT(ip_conntrack_module);
>> +    /* NULL if ip_connlimit not a module */
>> +    if (ip_connlimit_module)
>> +        __MOD_INC_USE_COUNT(ip_connlimit_module);
>>     return ipt_register_match(&connlimit_match);
>> }
>>
>>  
>
> AFAIK, the use of __MOD_INC_USE_COUNT is deprecated, actually I remember 
> that someone posted to the maillist a related issue and Harald finally 
> decided to remove them. If I'm missing anything, please let me know.

Hmmmm....I just looked at other modules to see how they do it, so 
__MOD_INC_USE_COUNT() still seems to be in use not only in this module.

> So I think that you could remove them, you could also post a patch to 
> update the current match available in pom-ng :-).

Can I really remove those lines completely?

-- 
MfG / Regards
Friedrich Lobenstock