From: "Horia Geantă" <horia.geanta@nxp.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Dominique MARTINET <dominique.martinet@atmark-techno.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
jianxiong Gao <jxgao@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lukas Hartmann <lukas@mntmn.com>,
Aymen Sghaier <aymen.sghaier@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
Bumyong Lee <bumyong.lee@samsung.com>,
Chanho Park <chanho61.park@samsung.com>
Subject: Re: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12)
Date: Fri, 11 Jun 2021 13:59:36 +0300 [thread overview]
Message-ID: <407997cd-dfa0-7b36-fa12-2baebdfcfff7@nxp.com> (raw)
In-Reply-To: <YMM8Ua0HMmErLIQg@0xbeefdead.lan>
On 6/11/2021 1:35 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 11, 2021 at 08:21:53AM +0200, Christoph Hellwig wrote:
>> On Thu, Jun 10, 2021 at 05:52:07PM +0300, Horia Geantă wrote:
>>> I've noticed the failure also in v5.10 and v5.11 stable kernels,
>>> since the patch set has been backported.
>>
>> FYI, there has been a patch on the list that should have fixed this
>> for about a month:
>>
>> https://lore.kernel.org/linux-iommu/20210510091816.GA2084@lst.de/T/#m0d0df6490350a08dcc24c9086c8edc165b402d6f
>>
>> but it seems like it never got picked up.
>
> Yikes!
>
> Dominique,
>
> Would you be up to testing the attached (and inline) patch please?
>
> Linus,
>
> Would you be terribly offended if I took your code (s/unsigned
> long/unsigned int), and used Chanho's description of the problem (see below)?
>
Both patches work for my case.
However, there's yet another, possibly significant, difference b/w the two:
offset = (tlb_addr - mem->start) & (IO_TLB_SIZE - 1);
vs.
offset = (tlb_addr & (IO_TLB_SIZE - 1)) -
swiotlb_align_offset(dev, orig_addr);
I think accounting for the alignment offset (swiotlb_align_offset())
has to be kept.
Horia
WARNING: multiple messages have this Message-ID (diff)
From: "Horia Geantă" <horia.geanta@nxp.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Dominique MARTINET <dominique.martinet@atmark-techno.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
jianxiong Gao <jxgao@google.com>
Cc: Aymen Sghaier <aymen.sghaier@nxp.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Lukas Hartmann <lukas@mntmn.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Bumyong Lee <bumyong.lee@samsung.com>,
"iommu@lists.linux-foundation.org"
<iommu@lists.linux-foundation.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
Chanho Park <chanho61.park@samsung.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12)
Date: Fri, 11 Jun 2021 13:59:36 +0300 [thread overview]
Message-ID: <407997cd-dfa0-7b36-fa12-2baebdfcfff7@nxp.com> (raw)
In-Reply-To: <YMM8Ua0HMmErLIQg@0xbeefdead.lan>
On 6/11/2021 1:35 PM, Konrad Rzeszutek Wilk wrote:
> On Fri, Jun 11, 2021 at 08:21:53AM +0200, Christoph Hellwig wrote:
>> On Thu, Jun 10, 2021 at 05:52:07PM +0300, Horia Geantă wrote:
>>> I've noticed the failure also in v5.10 and v5.11 stable kernels,
>>> since the patch set has been backported.
>>
>> FYI, there has been a patch on the list that should have fixed this
>> for about a month:
>>
>> https://lore.kernel.org/linux-iommu/20210510091816.GA2084@lst.de/T/#m0d0df6490350a08dcc24c9086c8edc165b402d6f
>>
>> but it seems like it never got picked up.
>
> Yikes!
>
> Dominique,
>
> Would you be up to testing the attached (and inline) patch please?
>
> Linus,
>
> Would you be terribly offended if I took your code (s/unsigned
> long/unsigned int), and used Chanho's description of the problem (see below)?
>
Both patches work for my case.
However, there's yet another, possibly significant, difference b/w the two:
offset = (tlb_addr - mem->start) & (IO_TLB_SIZE - 1);
vs.
offset = (tlb_addr & (IO_TLB_SIZE - 1)) -
swiotlb_align_offset(dev, orig_addr);
I think accounting for the alignment offset (swiotlb_align_offset())
has to be kept.
Horia
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2021-06-11 11:00 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 16:00 [GIT PULL] (swiotlb) stable/for-linus-5.12 Konrad Rzeszutek Wilk
2021-02-26 22:24 ` pr-tracker-bot
2021-06-08 2:35 ` swiotlb/caamjr regression (Was: [GIT PULL] (swiotlb) stable/for-linus-5.12) Dominique MARTINET
2021-06-10 14:52 ` Horia Geantă
2021-06-10 14:52 ` Horia Geantă
2021-06-10 19:41 ` Linus Torvalds
2021-06-10 19:41 ` Linus Torvalds
2021-06-10 23:20 ` Horia Geantă
2021-06-10 23:20 ` Horia Geantă
2021-06-11 6:21 ` Christoph Hellwig
2021-06-11 6:21 ` Christoph Hellwig
2021-06-11 10:34 ` Konrad Rzeszutek Wilk
2021-06-11 10:34 ` Konrad Rzeszutek Wilk
2021-06-11 10:59 ` Horia Geantă [this message]
2021-06-11 10:59 ` Horia Geantă
2021-06-11 16:21 ` Linus Torvalds
2021-06-11 16:21 ` Linus Torvalds
2021-06-16 20:49 ` Jianxiong Gao
2021-06-16 20:49 ` Jianxiong Gao via iommu
2021-06-17 0:27 ` Konrad Rzeszutek Wilk
2021-06-17 0:27 ` Konrad Rzeszutek Wilk
2021-06-17 0:39 ` Dominique MARTINET
2021-06-17 0:39 ` Dominique MARTINET
2021-06-17 5:12 ` Christoph Hellwig
2021-06-17 5:12 ` Christoph Hellwig
2021-06-17 5:36 ` Dominique MARTINET
2021-06-17 5:36 ` Dominique MARTINET
2021-06-18 18:01 ` Jianxiong Gao
2021-06-18 18:01 ` Jianxiong Gao via iommu
2021-06-21 2:03 ` Dominique MARTINET
2021-06-21 2:03 ` Dominique MARTINET
2021-06-21 2:55 ` Chanho Park
2021-06-21 2:55 ` Chanho Park
2021-06-21 4:14 ` 'Dominique MARTINET'
2021-06-21 4:14 ` 'Dominique MARTINET'
2021-06-21 13:16 ` Konrad Rzeszutek Wilk
2021-06-21 13:16 ` Konrad Rzeszutek Wilk
2021-06-22 7:48 ` 'Dominique MARTINET'
2021-06-22 7:48 ` 'Dominique MARTINET'
2021-06-22 21:58 ` Konrad Rzeszutek Wilk
2021-06-22 21:58 ` Konrad Rzeszutek Wilk
2021-06-22 23:04 ` 'Dominique MARTINET'
2021-06-22 23:04 ` 'Dominique MARTINET'
2021-06-17 11:33 ` Christoph Hellwig
2021-06-17 11:33 ` Christoph Hellwig
2021-06-11 16:01 ` Linus Torvalds
2021-06-11 16:01 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407997cd-dfa0-7b36-fa12-2baebdfcfff7@nxp.com \
--to=horia.geanta@nxp.com \
--cc=aymen.sghaier@nxp.com \
--cc=bumyong.lee@samsung.com \
--cc=chanho61.park@samsung.com \
--cc=davem@davemloft.net \
--cc=dominique.martinet@atmark-techno.com \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=iommu@lists.linux-foundation.org \
--cc=jxgao@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@mntmn.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.