All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@eurodev.net>
To: netfilter-devel@lists.netfilter.org,
	Harald Welte <laforge@netfilter.org>
Subject: [PATCH] minor portability issue in ip_queue
Date: Thu, 15 Apr 2004 13:40:03 +0200	[thread overview]
Message-ID: <407E7493.4020007@eurodev.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 352 bytes --]

Hi,

I think that there's a minor issue in ip_queue related to portability, 
actually most architectures use long as time_t and suseconds_t but some 
weird don't (parisc and sparc64).

So, If I'm not wrong, I think that maybe this could lead to some 
problems using ip_queue in those platforms. Whatever you think, please 
let me know.

regards,
Pablo

[-- Attachment #2: ip_queue-portability.patch --]
[-- Type: text/plain, Size: 782 bytes --]

--- linux-2.6.3-old/include/linux/netfilter_ipv4/ip_queue.h	2004-02-18 04:59:25.000000000 +0100
+++ linux-2.6.3-patched/include/linux/netfilter_ipv4/ip_queue.h	2004-04-15 13:25:41.000000000 +0200
@@ -21,8 +21,8 @@
 typedef struct ipq_packet_msg {
 	unsigned long packet_id;	/* ID of queued packet */
 	unsigned long mark;		/* Netfilter mark value */
-	long timestamp_sec;		/* Packet arrival time (seconds) */
-	long timestamp_usec;		/* Packet arrvial time (+useconds) */
+	time_t timestamp_sec;		/* Packet arrival time (seconds) */
+	suseconds_t timestamp_usec;	/* Packet arrvial time (+useconds) */
 	unsigned int hook;		/* Netfilter hook we rode in on */
 	char indev_name[IFNAMSIZ];	/* Name of incoming interface */
 	char outdev_name[IFNAMSIZ];	/* Name of outgoing interface */

                 reply	other threads:[~2004-04-15 11:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=407E7493.4020007@eurodev.net \
    --to=pablo@eurodev.net \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.