* [PATCH] minor portability issue in ip_queue
@ 2004-04-15 11:40 Pablo Neira
0 siblings, 0 replies; only message in thread
From: Pablo Neira @ 2004-04-15 11:40 UTC (permalink / raw)
To: netfilter-devel, Harald Welte
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
Hi,
I think that there's a minor issue in ip_queue related to portability,
actually most architectures use long as time_t and suseconds_t but some
weird don't (parisc and sparc64).
So, If I'm not wrong, I think that maybe this could lead to some
problems using ip_queue in those platforms. Whatever you think, please
let me know.
regards,
Pablo
[-- Attachment #2: ip_queue-portability.patch --]
[-- Type: text/plain, Size: 782 bytes --]
--- linux-2.6.3-old/include/linux/netfilter_ipv4/ip_queue.h 2004-02-18 04:59:25.000000000 +0100
+++ linux-2.6.3-patched/include/linux/netfilter_ipv4/ip_queue.h 2004-04-15 13:25:41.000000000 +0200
@@ -21,8 +21,8 @@
typedef struct ipq_packet_msg {
unsigned long packet_id; /* ID of queued packet */
unsigned long mark; /* Netfilter mark value */
- long timestamp_sec; /* Packet arrival time (seconds) */
- long timestamp_usec; /* Packet arrvial time (+useconds) */
+ time_t timestamp_sec; /* Packet arrival time (seconds) */
+ suseconds_t timestamp_usec; /* Packet arrvial time (+useconds) */
unsigned int hook; /* Netfilter hook we rode in on */
char indev_name[IFNAMSIZ]; /* Name of incoming interface */
char outdev_name[IFNAMSIZ]; /* Name of outgoing interface */
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-04-15 11:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-15 11:40 [PATCH] minor portability issue in ip_queue Pablo Neira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.