* [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-01 21:11 ` Hubert Jasudowicz
0 siblings, 0 replies; 10+ messages in thread
From: Hubert Jasudowicz @ 2021-07-01 21:11 UTC (permalink / raw)
To: qemu-devel
Cc: virtio-fs, Hubert Jasudowicz, qemu-trivial,
Dr. David Alan Gilbert, Stefan Hajnoczi
From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
---
tools/virtiofsd/fuse_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index fa4aff9b0e..fc2564a603 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
dir = qemu_get_local_state_pathname("run/virtiofsd");
if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
- fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
+ fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
__func__, dir, strerror(errno));
return false;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* [Virtio-fs] [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-01 21:11 ` Hubert Jasudowicz
0 siblings, 0 replies; 10+ messages in thread
From: Hubert Jasudowicz @ 2021-07-01 21:11 UTC (permalink / raw)
To: qemu-devel; +Cc: virtio-fs, Hubert Jasudowicz, qemu-trivial
From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
---
tools/virtiofsd/fuse_virtio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
index fa4aff9b0e..fc2564a603 100644
--- a/tools/virtiofsd/fuse_virtio.c
+++ b/tools/virtiofsd/fuse_virtio.c
@@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
dir = qemu_get_local_state_pathname("run/virtiofsd");
if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
- fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
+ fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
__func__, dir, strerror(errno));
return false;
}
--
2.32.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] virtiofsd: Add missing newline in error message
2021-07-01 21:11 ` [Virtio-fs] " Hubert Jasudowicz
@ 2021-07-01 21:55 ` Philippe Mathieu-Daudé
-1 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-01 21:55 UTC (permalink / raw)
To: Hubert Jasudowicz, qemu-devel
Cc: virtio-fs, qemu-trivial, Dr. David Alan Gilbert, Stefan Hajnoczi
On 7/1/21 11:11 PM, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Virtio-fs] [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-01 21:55 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 10+ messages in thread
From: Philippe Mathieu-Daudé @ 2021-07-01 21:55 UTC (permalink / raw)
To: Hubert Jasudowicz, qemu-devel; +Cc: virtio-fs, qemu-trivial
On 7/1/21 11:11 PM, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] virtiofsd: Add missing newline in error message
2021-07-01 21:11 ` [Virtio-fs] " Hubert Jasudowicz
(?)
@ 2021-07-05 13:06 ` Stefan Hajnoczi
-1 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2021-07-05 13:06 UTC (permalink / raw)
To: Hubert Jasudowicz
Cc: qemu-devel, Dr. David Alan Gilbert, virtio-fs, qemu-trivial
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Thu, Jul 01, 2021 at 11:11:48PM +0200, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-05 13:06 ` Stefan Hajnoczi
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2021-07-05 13:06 UTC (permalink / raw)
To: Hubert Jasudowicz
Cc: virtio-fs, qemu-trivial, qemu-devel, Dr. David Alan Gilbert
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Thu, Jul 01, 2021 at 11:11:48PM +0200, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Virtio-fs] [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-05 13:06 ` Stefan Hajnoczi
0 siblings, 0 replies; 10+ messages in thread
From: Stefan Hajnoczi @ 2021-07-05 13:06 UTC (permalink / raw)
To: Hubert Jasudowicz; +Cc: virtio-fs, qemu-trivial, qemu-devel
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Thu, Jul 01, 2021 at 11:11:48PM +0200, Hubert Jasudowicz wrote:
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] virtiofsd: Add missing newline in error message
2021-07-01 21:11 ` [Virtio-fs] " Hubert Jasudowicz
@ 2021-07-09 9:06 ` Laurent Vivier
-1 siblings, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2021-07-09 9:06 UTC (permalink / raw)
To: Hubert Jasudowicz, qemu-devel
Cc: virtio-fs, qemu-trivial, Dr. David Alan Gilbert, Stefan Hajnoczi
Le 01/07/2021 à 23:11, Hubert Jasudowicz a écrit :
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index fa4aff9b0e..fc2564a603 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
> dir = qemu_get_local_state_pathname("run/virtiofsd");
>
> if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
> - fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
> + fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
> __func__, dir, strerror(errno));
> return false;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Virtio-fs] [PATCH] virtiofsd: Add missing newline in error message
@ 2021-07-09 9:06 ` Laurent Vivier
0 siblings, 0 replies; 10+ messages in thread
From: Laurent Vivier @ 2021-07-09 9:06 UTC (permalink / raw)
To: Hubert Jasudowicz, qemu-devel; +Cc: virtio-fs, qemu-trivial
Le 01/07/2021 à 23:11, Hubert Jasudowicz a écrit :
> From: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
>
> Signed-off-by: Hubert Jasudowicz <hubert.jasudowicz@gmail.com>
> ---
> tools/virtiofsd/fuse_virtio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/virtiofsd/fuse_virtio.c b/tools/virtiofsd/fuse_virtio.c
> index fa4aff9b0e..fc2564a603 100644
> --- a/tools/virtiofsd/fuse_virtio.c
> +++ b/tools/virtiofsd/fuse_virtio.c
> @@ -917,7 +917,7 @@ static bool fv_socket_lock(struct fuse_session *se)
> dir = qemu_get_local_state_pathname("run/virtiofsd");
>
> if (g_mkdir_with_parents(dir, S_IRWXU) < 0) {
> - fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s",
> + fuse_log(FUSE_LOG_ERR, "%s: Failed to create directory %s: %s\n",
> __func__, dir, strerror(errno));
> return false;
> }
>
Applied to my trivial-patches branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 10+ messages in thread