Re: [PATCH 2/2] Input: bcm5974 - report ABS_MT_PRESSURE + remove redundant emulation code

[Matt Whitlock <linux@mattwhitlock.name>]

On Monday, 6 July 2015, at 9:11 pm, Henrik Rydberg wrote:
> > It's been four weeks, and I haven't heard back on this patch. I believe I've
> > implemented what was requested. Is there a problem with it?
> 
> I thought you did get response on this patch set, concerning the fabrication of
> force data? I seem to remember a mail from Dmitry about this, although I cannot
> find it now.

I don't have anything from Dmitry at all, even in my spam box. Maybe he discussed it with you only?

> I think your patch is a good reduction, all in accord with what we talked about,
> but I have doubts that it will not create regressions. From what I have seen so
> far, patch-wise, the best solution is to leave the code as it is.

So you believe that the current (in-tree) behavior is superior to either of my attempts thus far to fix it?

> I understand that the constraints now seem to depict the empty set, but maybe
> there is a third solution.

Can you characterize what an acceptable solution would look like? The behavior of the code as it stands is really not acceptable; the MacBook Pro touchpad's buggy behavior in Linux is extremely frustrating, relative to its flawless behavior in OS X. My patchset has not introduced any regressions that I can observe, and in fact it has nearly eliminated the spurious drags. (I still get one occasionally, but maybe at a rate of ~1% as often as I was seeing them before.)