Re: ipt_ACCOUNT accounting target released

[Patrick McHardy <kaber@trash.net>]

Thomas Jarosch wrote:
>>I'm pleased to announce the first alpha release
>>of the high performance ipt_ACCOUNT target module.
>>
>>You can find it here:
>>http://www.intra2net.com/opensource/ipt_account/
> 
> 
> Did anyone had a chance to take a look?
> I really would like to see this one in netfilter CVS ;-)

The pom-ng tar has the include and net directory in the
ACCOUNT directory. You need to place them inside the
linux directory. Also, the target is very long (>1000 lines)
and formatted improperly, this makes it hard to review.
Please stick to Documentation/CodingStyle, especially
regaring overly long lines (>80 chars) and wasted lines:

     if (table_nr == -1)
     {

should be:

     if (table_nr == -1) {

C-style comments are prefered over C++-style comments.
It also looks like some common blocks of code could
be placed in a seperate function, for example the inner
blocks in ipt_account_handle_get_data(). Why does it
need a PAGE_SIZE >= 4096 ?

Please post the patch to the list for easier review.

Regards
Patrick

> 
> Thomas