Re: ipt_ACCOUNT accounting target released

[Patrick McHardy <kaber@trash.net>]

Thomas Jarosch wrote:
> Thanks for your reply. I'll fix the coding style
> and will post a new patch soon.

Thanks.

> Premature optimization is the root of all evil ;-)
> Is see what I can do, but IMHO this will increase
> the complexity of the ipt_account_handle_get_data() function.
> 
>>Why does it need a PAGE_SIZE >= 4096 ?
> 
> The internal data layout for a 8 bit network (256 hosts/CLASS C) is
> designed to fit into a kernel zero page. As the code is designed for constant
> (meaning every second/every 10 seconds) readout of the data,
> kmalloc would be too expensive as snapshots of the data are created.

Are you sure kmalloc is too slow for once a second allocations ?
Or could this be a premature optimization ? ;) Anyway, PAGE_SIZE
is a constant so you can check at compile time:

#if (PAGE_SIZE < 4096)
#error "..."
#endif

One more thing:

             if (copy_to_user(...))
             {
                 printk("ACCOUNT: ...");

Just return -EFAULT.

             if (handle.handle_nr >= ACCOUNT_MAX_HANDLES)
             {
                 printk("ACCOUNT: ...);
-EINVAL.


Regards
Patrick