Re: [PATCH] Reinstantiating stale inodes

[Steve Dickson <SteveD@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 678 bytes --]

Trond Myklebust wrote:

>I certainly would not expect any difference between the two when looking
>at the standard connectathon suite.
>  
>
Nor did I... I kinda thought it would reduce traffic.... but over the 
last few days,
I've tried a number of combinations of ctime and mtime to 1) fix the 
estale problem and
2) not added more traffic...  unfortunately with no success....

So I would like to propose a less intrusive patch what will simply zap
the directories caches when nfs_revalidate() sees an ESTALE.

This patch does not effect traffic and only the first dir entry is 
failed with ESTALE
and finally subsequent ls will not fail with ESTALEs....

Comments?

SteveD.

[-- Attachment #2: linux-2.4.21-nfs-estale3.patch --]
[-- Type: text/plain, Size: 553 bytes --]

--- linux-2.4.21/fs/nfs/inode.c.org	2004-05-03 08:57:36.000000000 -0400
+++ linux-2.4.21/fs/nfs/inode.c	2004-05-03 15:03:57.000000000 -0400
@@ -958,8 +958,16 @@ nfs_wait_on_inode(struct inode *inode, i
 int
 nfs_revalidate(struct dentry *dentry)
 {
+	int error;
 	struct inode *inode = dentry->d_inode;
-	return nfs_revalidate_inode(NFS_SERVER(inode), inode);
+	
+	error = nfs_revalidate_inode(NFS_SERVER(inode), inode);
+	if (error == -ESTALE) {
+		struct inode *dir = dentry->d_parent->d_inode;
+		nfs_zap_caches(dir);	
+	}
+
+	return error;
 }
 
 /*