All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: Re: [PATCH 4/5] arm64: dts: renesas: r8a77995: draak: Add backlight
Date: Mon, 10 Dec 2018 14:33:08 +0200	[thread overview]
Message-ID: <4097394.UXB4c1edBM@avalon> (raw)
In-Reply-To: <CAMuHMdUKxTVuroRuwQCWp9OZufJKRSM-dN_ee0zKj9OhNy273Q@mail.gmail.com>

Hi Geert,

On Monday, 10 December 2018 14:30:22 EET Geert Uytterhoeven wrote:
> On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven wrote:
> > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart wrote:
> >> Add the backlight device for the LVDS1 output, in preparation for panel
> >> support.
> >> 
> >> Signed-off-by: Laurent Pinchart
> >> <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Oops, seems I missed the backlight node should be moved up, to preserve
> sort order.

I assumed that aliases and chosen should be kept at the top of the file. Maybe 
we don't want to keep the tradition :-)

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Kieran Bingham <kieran.bingham@ideasonboard.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 4/5] arm64: dts: renesas: r8a77995: draak: Add backlight
Date: Mon, 10 Dec 2018 14:33:08 +0200	[thread overview]
Message-ID: <4097394.UXB4c1edBM@avalon> (raw)
In-Reply-To: <CAMuHMdUKxTVuroRuwQCWp9OZufJKRSM-dN_ee0zKj9OhNy273Q@mail.gmail.com>

Hi Geert,

On Monday, 10 December 2018 14:30:22 EET Geert Uytterhoeven wrote:
> On Tue, Dec 4, 2018 at 6:36 PM Geert Uytterhoeven wrote:
> > On Sun, Nov 25, 2018 at 3:40 PM Laurent Pinchart wrote:
> >> Add the backlight device for the LVDS1 output, in preparation for panel
> >> support.
> >> 
> >> Signed-off-by: Laurent Pinchart
> >> <laurent.pinchart+renesas@ideasonboard.com>
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Oops, seems I missed the backlight node should be moved up, to preserve
> sort order.

I assumed that aliases and chosen should be kept at the top of the file. Maybe 
we don't want to keep the tradition :-)

-- 
Regards,

Laurent Pinchart



_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-12-10 12:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 14:40 [PATCH 0/5] R-Car DU: Fix DPAD output routing on D3 and E3 Laurent Pinchart
2018-11-25 14:40 ` Laurent Pinchart
2018-11-25 14:40 ` [PATCH 1/5] drm: rcar-du: Replace EXT_CTRL_REGS feature flag with generation check Laurent Pinchart
2018-11-25 14:40   ` Laurent Pinchart
2018-11-26  8:36   ` Simon Horman
2018-11-26  8:36     ` Simon Horman
2018-12-07 11:39   ` Kieran Bingham
2018-12-07 11:39     ` Kieran Bingham
2018-11-25 14:40 ` [PATCH 2/5] drm: rcar-du: Move CRTC outputs bitmask to private CRTC state Laurent Pinchart
2018-11-25 14:40   ` Laurent Pinchart
2018-12-07 12:34   ` Kieran Bingham
2018-12-07 12:34     ` Kieran Bingham
2018-12-09 20:40     ` Laurent Pinchart
2018-12-09 20:40       ` Laurent Pinchart
2018-11-25 14:40 ` [PATCH 3/5] drm: rcar-du: Disable unused DPAD outputs Laurent Pinchart
2018-11-25 14:40   ` Laurent Pinchart
2018-12-07 12:50   ` Kieran Bingham
2018-12-07 12:50     ` Kieran Bingham
2018-12-07 22:38     ` Laurent Pinchart
2018-12-07 22:38       ` Laurent Pinchart
2018-12-09 20:44   ` [PATCH v1.1 " Laurent Pinchart
2018-12-09 20:44     ` Laurent Pinchart
2018-11-25 14:40 ` [PATCH 4/5] arm64: dts: renesas: r8a77995: draak: Add backlight Laurent Pinchart
2018-11-25 14:40   ` Laurent Pinchart
2018-12-04 16:57   ` Laurent Pinchart
2018-12-04 16:57     ` Laurent Pinchart
2018-12-05 19:47     ` Simon Horman
2018-12-05 19:47       ` Simon Horman
2018-12-04 17:36   ` Geert Uytterhoeven
2018-12-04 17:36     ` Geert Uytterhoeven
2018-12-10 12:30     ` Geert Uytterhoeven
2018-12-10 12:30       ` Geert Uytterhoeven
2018-12-10 12:33       ` Laurent Pinchart [this message]
2018-12-10 12:33         ` Laurent Pinchart
2018-12-12 10:58         ` Simon Horman
2018-12-12 10:58           ` Simon Horman
2018-11-25 14:40 ` [PATCH 5/5] [HACK] arm64: dts: r8a77995: draak: Add panel to DT Laurent Pinchart
2018-11-25 14:40   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4097394.UXB4c1edBM@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert@linux-m68k.org \
    --cc=kieran.bingham@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.