All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: Marek Vasut <marex@denx.de>,
	devicetree@vger.kernel.org,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:MEDIA DRIVERS FOR RENESAS - FCP"
	<linux-renesas-soc@vger.kernel.org>,
	Linux I2C <linux-i2c@vger.kernel.org>,
	Matt Porter <mporter@konsulko.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v4 06/16] of: unittest: changeset helpers
Date: Thu, 22 Feb 2018 01:39:58 +0200	[thread overview]
Message-ID: <4098480.WkPaFBmRlF@avalon> (raw)
In-Reply-To: <CAL_Jsq+D4wwPSZbSXrJpwcNvB1Xth=Cn-bTyXL2RkSOb9s+d_A@mail.gmail.com>

Hi Rob,

On Thursday, 22 February 2018 01:10:25 EET Rob Herring wrote:
> On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote:
> > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> > 
> > Add a unitest specific for the new changeset helpers.
> > 
> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/of/unittest.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> > 
> > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> > index 7a9abaae874d..1b21d2c549a8 100644
> > --- a/drivers/of/unittest.c
> > +++ b/drivers/of/unittest.c
> > @@ -609,6 +609,59 @@ static void __init of_unittest_changeset(void)
> > 
> >  #endif
> >  }
> > 
> > +static void __init of_unittest_changeset_helper(void)
> > +{
> > +#ifdef CONFIG_OF_DYNAMIC
> 
> I think this can be:
> 
> if (!IS_ENABLED(CONFIG_OF_DYNAMIC))
>   return;

Not quite, as there are functions used below (such as of_changeset_init()) 
that are not defined if CONFIG_OF_DYNAMIC isn't enabled. We could create stubs 
in that case but I believe that's out of scope for this patch series.

> Otherwise,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rob Herring <robh@kernel.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:MEDIA DRIVERS FOR RENESAS - FCP"
	<linux-renesas-soc@vger.kernel.org>,
	Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Matt Porter <mporter@konsulko.com>,
	Koen Kooi <koen@dominion.thruhere.net>,
	Guenter Roeck <linux@roeck-us.net>, Marek Vasut <marex@denx.de>,
	Wolfram Sang <wsa@the-dreams.de>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v4 06/16] of: unittest: changeset helpers
Date: Thu, 22 Feb 2018 01:39:58 +0200	[thread overview]
Message-ID: <4098480.WkPaFBmRlF@avalon> (raw)
In-Reply-To: <CAL_Jsq+D4wwPSZbSXrJpwcNvB1Xth=Cn-bTyXL2RkSOb9s+d_A@mail.gmail.com>

Hi Rob,

On Thursday, 22 February 2018 01:10:25 EET Rob Herring wrote:
> On Tue, Feb 20, 2018 at 5:10 PM, Laurent Pinchart wrote:
> > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> > 
> > Add a unitest specific for the new changeset helpers.
> > 
> > Signed-off-by: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >  drivers/of/unittest.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 54 insertions(+)
> > 
> > diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
> > index 7a9abaae874d..1b21d2c549a8 100644
> > --- a/drivers/of/unittest.c
> > +++ b/drivers/of/unittest.c
> > @@ -609,6 +609,59 @@ static void __init of_unittest_changeset(void)
> > 
> >  #endif
> >  }
> > 
> > +static void __init of_unittest_changeset_helper(void)
> > +{
> > +#ifdef CONFIG_OF_DYNAMIC
> 
> I think this can be:
> 
> if (!IS_ENABLED(CONFIG_OF_DYNAMIC))
>   return;

Not quite, as there are functions used below (such as of_changeset_init()) 
that are not defined if CONFIG_OF_DYNAMIC isn't enabled. We could create stubs 
in that case but I believe that's out of scope for this patch series.

> Otherwise,
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2018-02-21 23:39 UTC|newest]

Thread overview: 99+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-20 23:10 [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Laurent Pinchart
2018-02-20 23:10 ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 01/16] dt-bindings: display: renesas: Add R-Car LVDS encoder DT bindings Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21  8:35   ` Sergei Shtylyov
2018-02-21  8:35     ` Sergei Shtylyov
2018-02-21 19:50     ` Laurent Pinchart
2018-02-21 19:50       ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 02/16] dt-bindings: display: renesas: Deprecate LVDS support in the DU bindings Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 03/16] of: dynamic: Add __of_node_dupv() Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 10:26   ` Geert Uytterhoeven
2018-02-21 10:26     ` Geert Uytterhoeven
2018-02-21 12:15     ` Laurent Pinchart
2018-02-21 12:15       ` Laurent Pinchart
2018-02-21 23:16   ` Rob Herring
2018-02-21 23:16     ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 04/16] of: changesets: Introduce changeset helper methods Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 10:21   ` Geert Uytterhoeven
2018-02-21 10:21     ` Geert Uytterhoeven
2018-02-21 12:19     ` Laurent Pinchart
2018-02-21 12:19       ` Laurent Pinchart
2018-02-21 15:23     ` Rob Herring
2018-02-21 15:23       ` Rob Herring
2018-02-21 15:46       ` Geert Uytterhoeven
2018-02-21 15:46         ` Geert Uytterhoeven
2018-02-21 23:14   ` Rob Herring
2018-02-21 23:14     ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 05/16] of: changeset: Add of_changeset_node_move method Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 23:20   ` Rob Herring
2018-02-21 23:20     ` Rob Herring
2018-02-21 23:40     ` Laurent Pinchart
2018-02-21 23:40       ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 06/16] of: unittest: changeset helpers Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 23:10   ` Rob Herring
2018-02-21 23:10     ` Rob Herring
2018-02-21 23:39     ` Laurent Pinchart [this message]
2018-02-21 23:39       ` Laurent Pinchart
2018-02-21 23:49       ` Rob Herring
2018-02-21 23:49         ` Rob Herring
2018-02-20 23:10 ` [PATCH v4 07/16] i2c: demux: Use changeset helpers for clarity Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21  8:06   ` Wolfram Sang
2018-02-21  8:06     ` Wolfram Sang
2018-02-20 23:10 ` [PATCH v4 08/16] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 23:28   ` Rob Herring
2018-02-21 23:28     ` Rob Herring
2018-02-21 23:54     ` Laurent Pinchart
2018-02-21 23:54       ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 09/16] drm: rcar-du: Convert LVDS encoder code to bridge driver Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 10/16] ARM: dts: r8a7790: Convert to new LVDS DT bindings Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 11/16] ARM: dts: r8a7791: " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-23  9:32   ` Sergei Shtylyov
2018-02-23  9:32     ` Sergei Shtylyov
2018-02-23  9:37     ` Laurent Pinchart
2018-02-23  9:37       ` Laurent Pinchart
2018-02-23  9:51   ` Sergei Shtylyov
2018-02-23  9:51     ` Sergei Shtylyov
2018-02-27 10:26     ` Laurent Pinchart
2018-02-27 10:26       ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 12/16] ARM: dts: r8a7792: Convert to new DU " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 13/16] ARM: dts: r8a7793: Convert to new LVDS " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 14/16] ARM: dts: r8a7794: Convert to new DU " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21  8:26   ` Sergei Shtylyov
2018-02-21  8:26     ` Sergei Shtylyov
2018-02-20 23:10 ` [PATCH v4 15/16] arm64: dts: renesas: r8a7795: Convert to new LVDS " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-20 23:10 ` [PATCH v4 16/16] arm64: dts: renesas: r8a7796: " Laurent Pinchart
2018-02-20 23:10   ` Laurent Pinchart
2018-02-21 16:39 ` [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver Simon Horman
2018-02-21 16:39   ` Simon Horman
2018-05-24  8:00   ` Laurent Pinchart
2018-05-25 10:13     ` Simon Horman
2018-05-25 10:23       ` Laurent Pinchart
2018-05-28  9:39         ` Simon Horman
2018-05-28  9:45           ` Laurent Pinchart
2018-05-28 10:29             ` Simon Horman
2018-06-05  8:16               ` Simon Horman
2018-02-22  6:07 ` Frank Rowand
2018-02-22  6:07   ` Frank Rowand
2018-02-22 10:25   ` Laurent Pinchart
2018-02-22 10:25     ` Laurent Pinchart
2018-02-23  3:20     ` Frank Rowand
2018-02-23  3:20       ` Frank Rowand
2018-02-23  9:25       ` Laurent Pinchart
2018-02-23  9:25         ` Laurent Pinchart
2018-02-23 19:35         ` Frank Rowand
2018-02-23 19:35           ` Frank Rowand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4098480.WkPaFBmRlF@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frowand.list@gmail.com \
    --cc=koen@dominion.thruhere.net \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marex@denx.de \
    --cc=mporter@konsulko.com \
    --cc=pantelis.antoniou@konsulko.com \
    --cc=robh@kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.