[PATCH] Pom-ng: test return code from File::Copy

[PATCH] Pom-ng: test return code from File::Copy

[Martijn Lievaart]

[-- Attachment #1: Type: text/plain, Size: 178 bytes --]

Hi,

Trying to work out how POM-ng works, I found a slight bug. The 
returncode from the File::Copy routine is not tested. Attached patch 
fixes that.

Cheers,
Martijn Lievaart


[-- Attachment #2: file_copy_patch --]
[-- Type: text/plain, Size: 490 bytes --]

--- patch-o-matic-ng/Netfilter_POM.pm	2004-05-05 12:24:04.000000000 +0200
+++ patch-o-matic-ng.new/Netfilter_POM.pm	2004-05-05 18:49:26.000000000 +0200
@@ -682,7 +683,10 @@
 						return 0;
 					}
 				}
-				File::Copy::copy($srcfile, $destfile);
+				if (!File::Copy::copy($srcfile, $destfile)) {
+					$self->{ERRMSG} .= "unable to copy $srcfile to $destfile: $!\n";
+					return 0;
+				}
 				# .foo-test is executable
 				chmod((stat($srcfile))[2] & 07777, $destfile);
 			} else {

Re: [PATCH] Pom-ng: test return code from File::Copy

[Jozsef Kadlecsik]

On Wed, 5 May 2004, Martijn Lievaart wrote:

> Trying to work out how POM-ng works, I found a slight bug. The
> returncode from the File::Copy routine is not tested. Attached patch
> fixes that.

Patch applied, thank you Martijn.

Best regards,
Jozsef
-
E-mail  : kadlec@blackhole.kfki.hu, kadlec@sunserv.kfki.hu
PGP key : http://www.kfki.hu/~kadlec/pgp_public_key.txt
Address : KFKI Research Institute for Particle and Nuclear Physics
          H-1525 Budapest 114, POB. 49, Hungary