All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Furniss <andy.furniss@dsl.pipex.com>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] HTB MPU
Date: Fri, 14 May 2004 08:40:44 +0000	[thread overview]
Message-ID: <40A4860C.8070004@dsl.pipex.com> (raw)
In-Reply-To: <40A37E1B.8060604@dsl.pipex.com>

Ed Wildgoose wrote:
> Andy Furniss wrote:
> 
>> Hi.
>>
>> I wrote in a reply to a mail on here recently that you can't set mpu 
>> (minimum packet unit) on HTB as you can on CBQ.
>>
>> I've just noticed that there is a patch on devik's site which does mpu 
>> and overhead.
>>
>> http://luxik.cdi.cz/~devik/qos/htb/
>>
>> For dsl users mpu is, for practical purposes going to be 106 - 
>> overhead is still variable though, depending on packet size.
>>
>> Having these should let you push upstream bandwidth rates a bit closer 
>> to the limit.
> 
> 
> 
> What about changing that patch a little (bear in mind I don't understand 
> how it works though).
> I appears that you could change the patch in tc/core in fn 
> tc_calc_rtable, from:
> 
>  + if (overhead)
>  +     sz += overhead;
> 
> to something like:
> 
>  + if (overhead)
>  +     sz += (((sz-1)/mpu)+1) * overhead;
> 
> Where that little calculation is trying to turn the mpu into a packet 
> size, work out how many packets would be required for the size (sz) of 
> data, and apply the overhead per packet.  You would then set mpu to be 
> the atm packet size, ie 54
> 
> To be honest though, this packing of the params into a single var seems 
> unneccessary.  The function  tc_calc_rtab is only obviously used in the 
> tc code, and it could be easily changed to have a prototype with an 
> extra param.  I would have to have a flick through the rest of the code, 
> but it might be quite easy to add per packet overhead to the cbq code in 
> the same way, and also whatever m_police is?
> 
> Can someone with a working setup try this out and see if it helps?

The patch author has mailed with similar suggestion, so there may be 
something new soon. People will need to work out their ppp overhead 
first. I know mine for pppoa/vc mux in the UK - it's 10 (the RFC says 9 
or 10) so it's lucky my modem gives a cell count so I can tell easily.
I don't know how many there are, or what figure other variants use.

Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

  parent reply	other threads:[~2004-05-14  8:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-13 13:54 [LARTC] HTB MPU Andy Furniss
2004-05-13 14:38 ` Andreas Klauer
2004-05-13 17:28 ` Andreas Klauer
2004-05-13 21:59 ` Jason Boxman
2004-05-14  7:05 ` Ed Wildgoose
2004-05-14  8:40 ` Andy Furniss [this message]
2004-05-14  9:55 ` Andy Furniss
2004-05-14 17:10 ` Jason Boxman
2004-05-17 22:36 ` Andy Furniss
2004-05-17 23:33 ` Andy Furniss
2004-05-20  6:29 ` Jason Boxman
2004-05-20 11:13 ` Andy Furniss
2004-05-21  8:19 ` syrius.ml
2004-05-24 20:53 ` Jason Boxman
2004-05-24 23:42 ` Ed Wildgoose
2004-05-28 18:54 ` Andy Furniss
2004-05-28 19:18 ` Jason Boxman
2004-05-28 21:49 ` Ed Wildgoose
2004-05-30  7:40 ` Andy Furniss
2004-05-30  7:49 ` Andy Furniss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40A4860C.8070004@dsl.pipex.com \
    --to=andy.furniss@dsl.pipex.com \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.