All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] befs (1/5): LBD support
@ 2004-05-13 18:32 Sergey S. Kostyliov
  2004-05-14  2:16 ` Andrew Morton
  2004-05-14 15:22 ` Will Dyson
  0 siblings, 2 replies; 8+ messages in thread
From: Sergey S. Kostyliov @ 2004-05-13 18:32 UTC (permalink / raw)
  To: linux-kernel; +Cc: Will Dyson

LBD patch merged long time ago, so it is safe to pass u64 block
numbers to sb_bread() when sector_t is large enough.

===== fs/befs/linuxvfs.c 1.17 vs edited =====
--- 1.17/fs/befs/linuxvfs.c	Thu Mar  4 18:03:10 2004
+++ edited/fs/befs/linuxvfs.c	Thu May 13 21:23:04 2004
@@ -856,6 +856,13 @@
 	if (befs_check_sb(sb) != BEFS_OK)
 		goto unaquire_priv_sbp;
 
+	if( befs_sb->num_blocks > ~((sector_t)0) ) {
+		befs_error(sb, "blocks count: %Lu "
+			"is larger than the host can use",
+			befs_sb->num_blocks);
+		goto unaquire_priv_sbp;
+	}
+
 	/*
 	 * set up enough so that it can read an inode
 	 * Fill in kernel superblock fields from private sb
===== fs/befs/befs.h 1.1 vs edited =====
--- 1.1/fs/befs/befs.h	Tue Oct 22 18:39:38 2002
+++ edited/fs/befs/befs.h	Thu May 13 21:22:53 2004
@@ -14,10 +14,7 @@
 #define BEFS_VERSION "0.9.3"
 
 
-/* Sector_t makes this sillyness obsolete */
 typedef u64 befs_blocknr_t;
-typedef u32 vfs_blocknr_t;
-
 /*
  * BeFS in memory structures
  */
===== fs/befs/io.c 1.1 vs edited =====
--- 1.1/fs/befs/io.c	Tue Oct 22 18:39:38 2002
+++ edited/fs/befs/io.c	Thu May 13 21:22:53 2004
@@ -28,7 +28,6 @@
 {
 	struct buffer_head *bh = NULL;
 	befs_blocknr_t block = 0;
-	vfs_blocknr_t vfs_block = 0;
 	befs_sb_info *befs_sb = BEFS_SB(sb);
 
 	befs_debug(sb, "---> Enter befs_read_iaddr() "
@@ -42,17 +41,10 @@
 	}
 
 	block = iaddr2blockno(sb, &iaddr);
-	vfs_block = (vfs_blocknr_t) block;
-
-	if (vfs_block != block) {
-		befs_error(sb, "Error converting to host blocknr_t. %Lu "
-			   "is larger than the host can use", block);
-		goto error;
-	}
 
 	befs_debug(sb, "befs_read_iaddr: offset = %lu", block);
 
-	bh = sb_bread(sb, vfs_block);
+	bh = sb_bread(sb, block);
 
 	if (bh == NULL) {
 		befs_error(sb, "Failed to read block %lu", block);
@@ -71,20 +63,13 @@
 befs_bread(struct super_block *sb, befs_blocknr_t block)
 {
 	struct buffer_head *bh = NULL;
-	vfs_blocknr_t vfs_block = (vfs_blocknr_t) block;
 
 	befs_debug(sb, "---> Enter befs_read() %Lu", block);
 
-	if (vfs_block != block) {
-		befs_error(sb, "Error converting to host blocknr_t. %Lu "
-			   "is larger than the host can use", block);
-		goto error;
-	}
-
-	bh = sb_bread(sb, vfs_block);
+	bh = sb_bread(sb, block);
 
 	if (bh == NULL) {
-		befs_error(sb, "Failed to read block %lu", vfs_block);
+		befs_error(sb, "Failed to read block %lu", block);
 		goto error;
 	}
 

-- 
                   Best regards,
                   Sergey S. Kostyliov <rathamahata@php4.ru>
                   Public PGP key: http://sysadminday.org.ru/rathamahata.asc


^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2004-05-14 16:59 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-13 18:32 [PATCH] befs (1/5): LBD support Sergey S. Kostyliov
2004-05-14  2:16 ` Andrew Morton
2004-05-14 13:00   ` Sergey S. Kostyliov
2004-05-14 15:22 ` Will Dyson
2004-05-14 16:09   ` Sergey S. Kostyliov
2004-05-14 16:33     ` Will Dyson
2004-05-14 16:33     ` Jörn Engel
2004-05-14 16:58       ` Sergey S. Kostyliov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.