All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU crash with Fedora Core 2
Date: Wed, 26 May 2004 22:04:49 +0200	[thread overview]
Message-ID: <40B4F861.7000504@bellard.org> (raw)
In-Reply-To: <1085562014.3456.1171.camel@hades.cambridge.redhat.com>

I cannot accept this patch: it breaks qemu-fast with all old libcs. The 
good solution is to use a specific sigaction call which directly makes 
the sigaction Linux system call.

Fabrice.

David Woodhouse wrote:
> On Wed, 2004-05-26 at 01:47 +0300, Hetz Ben Hamo wrote:
> 
>>qemu: relocation error: qemu: symbol __libc_sigaction, version GLIBC_PRIVATE 
>>not defined in file libc.so.6 with link time reference
>>
>>Googling this error brings a link to a redhat 7.3 bug ;)
> 
> 
> __libc_sigaction is a glibc private function. Explicitly linking to it
> is an application bug. 
> 
> I believe it's done to work around an old linuxthreads-related SDL bug
> which doesn't actually exist any more.
> 
> --- qemu-0.5.4/vl.c.orig	2004-05-02 11:58:59.852195291 +0100
> +++ qemu-0.5.4/vl.c	2004-05-02 11:59:37.856959391 +0100
> @@ -56,18 +56,6 @@
>  #define memalign(align, size) malloc(size)
>  #endif
>  
> -#ifdef CONFIG_SDL
> -/* SDL use the pthreads and they modify sigaction. We don't
> -   want that. */
> -#if __GLIBC__ > 2 || (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 2)
> -extern void __libc_sigaction();
> -#define sigaction(sig, act, oact) __libc_sigaction(sig, act, oact)
> -#else
> -extern void __sigaction();
> -#define sigaction(sig, act, oact) __sigaction(sig, act, oact)
> -#endif
> -#endif /* CONFIG_SDL */
> -
>  #include "disas.h"
>  
>  #include "exec-all.h"
> 
> 

  parent reply	other threads:[~2004-05-27  3:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-25 22:47 [Qemu-devel] QEMU crash with Fedora Core 2 Hetz Ben Hamo
2004-05-26  9:00 ` David Woodhouse
2004-05-26 14:24   ` Hetz Ben Hamo
2004-05-26 20:04   ` Fabrice Bellard [this message]
2004-05-27  6:36     ` Hetz Ben Hamo
2004-05-27  6:57     ` Alexander E. Patrakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40B4F861.7000504@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.