From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: schizo@debian.org, mcgrof@studorgs.rutgers.edu,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
prism54-devel@prism54.org, debian-kernel@lists.debian.org
Subject: Re: [Prism54-devel] Re: [PATCH 0/14] prism54: bring up to sync with prism54.org cvs rep
Date: Thu, 27 May 2004 15:24:51 -0400 [thread overview]
Message-ID: <40B64083.9050200@pobox.com> (raw)
In-Reply-To: <20040527120544.2fbd4b35.akpm@osdl.org>
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>> Luis, you, or somebody should create a new patch series with just the
>> critical fixes, NO WHITESPACE/FORMATTING CHANGES mixed in, and send
>> those first.
>
>
> Whitespace changes are often nice, but they should be the very first
> patch[es] in the series. You should be able to verify that the .o file was
> unchanged before and after.
Very first, or very last. I leave that up to the maintainer.
> That way they become a no-brainer and it becomes easier to review and
> understand the substantive changes.
Agreed.
Further, when someone mixes an Lindent in with functional changes, I
become very suspicious. That is precisely the method that certain high
profile Linux hackers have used in the past to intentionally obfuscate
security changes.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Morton <akpm@osdl.org>
Cc: schizo@debian.org, mcgrof@studorgs.rutgers.edu,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
prism54-devel@prism54.org, debian-kernel@lists.debian.org
Subject: Re: Re: [PATCH 0/14] prism54: bring up to sync with prism54.org cvs rep
Date: Thu, 27 May 2004 15:24:51 -0400 [thread overview]
Message-ID: <40B64083.9050200@pobox.com> (raw)
In-Reply-To: <20040527120544.2fbd4b35.akpm@osdl.org>
Andrew Morton wrote:
> Jeff Garzik <jgarzik@pobox.com> wrote:
>
>> Luis, you, or somebody should create a new patch series with just the
>> critical fixes, NO WHITESPACE/FORMATTING CHANGES mixed in, and send
>> those first.
>
>
> Whitespace changes are often nice, but they should be the very first
> patch[es] in the series. You should be able to verify that the .o file was
> unchanged before and after.
Very first, or very last. I leave that up to the maintainer.
> That way they become a no-brainer and it becomes easier to review and
> understand the substantive changes.
Agreed.
Further, when someone mixes an Lindent in with functional changes, I
become very suspicious. That is precisely the method that certain high
profile Linux hackers have used in the past to intentionally obfuscate
security changes.
Jeff
next prev parent reply other threads:[~2004-05-27 19:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 8:30 [PATCH 0/14] prism54: bring up to sync with prism54.org cvs rep Luis R. Rodriguez
2004-05-24 8:57 ` Luis R. Rodriguez
2004-05-24 8:57 ` Luis R. Rodriguez
2004-05-27 18:10 ` Jeff Garzik
2004-05-27 19:27 ` Marcelo Tosatti
2004-05-27 19:32 ` Jeff Garzik
2004-05-27 19:45 ` [Prism54-devel] " Luis R. Rodriguez
2004-05-27 19:45 ` Luis R. Rodriguez
2004-05-27 19:56 ` [Prism54-devel] " Jeff Garzik
2004-05-27 19:56 ` Jeff Garzik
2004-05-27 20:04 ` Luis R. Rodriguez
2004-05-27 18:19 ` Jeff Garzik
2004-05-27 18:25 ` [Prism54-devel] " Clint Adams
2004-05-27 18:25 ` Clint Adams
2004-05-27 18:40 ` [Prism54-devel] " Jeff Garzik
2004-05-27 18:40 ` Jeff Garzik
2004-05-27 19:05 ` [Prism54-devel] " Andrew Morton
2004-05-27 19:24 ` Jeff Garzik [this message]
2004-05-27 19:24 ` Jeff Garzik
2004-05-27 18:39 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40B64083.9050200@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=debian-kernel@lists.debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@studorgs.rutgers.edu \
--cc=netdev@oss.sgi.com \
--cc=prism54-devel@prism54.org \
--cc=schizo@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.