From: Zach Brown <zab@zabbo.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] linux-2.6.7-rc2/fs/cifs/cifsfs.c
Date: Mon, 07 Jun 2004 16:48:29 +0000 [thread overview]
Message-ID: <40C49C5D.9070907@zabbo.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0406060258100.19187@mustang.cs.nmsu.edu>
[-- Attachment #1: Type: text/plain, Size: 538 bytes --]
> + rc = register_filesystem(&cifs_fs_type);
> + if (!rc) {
> + printk(KERN_ERR "Couldn't register cifs.\n");
If you're going to go to the trouble of printing anything you should
include the return code. It would drive my batty if I had chased that
error down into the source and found that it missed the opportunity to
give me a hint as to why things failed.
> #ifdef CONFIG_PROC_FS
> cifs_proc_clean();
> #endif
(in other news, there might be an opportunity to lose this ifdef by
defining a no-op cifs_proc_clean in a header)
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2004-06-07 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-06 9:02 [Kernel-janitors] [PATCH] linux-2.6.7-rc2/fs/cifs/cifsfs.c MJK
2004-06-07 16:48 ` Zach Brown [this message]
2004-06-08 7:38 ` MJK
2004-06-08 15:49 ` [Kernel-janitors] [PATCH] linux-2.6.7-rc2/fs/cifs/cifsf Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40C49C5D.9070907@zabbo.net \
--to=zab@zabbo.net \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.