All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zab@zabbo.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] [PATCH] linux-2.6.7-rc2/fs/cifs/cifsf
Date: Tue, 08 Jun 2004 15:49:23 +0000	[thread overview]
Message-ID: <40C5E003.1090100@zabbo.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0406060258100.19187@mustang.cs.nmsu.edu>

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

 (Walter Harms) wrote:
> hi zach,
> i have rewritten the ini already. what do you mean nop cifs_proc_clean?
> somelike that ?

Something like that, yeah..

#ifdef CONFIG_PROC_FS
void cifs_proc_clean(void); /* usual prototype */
#else
#define cifs_proc_clean() do { } while (0)
#endif

This might not make sense if cifs_proc_clean() is in the same file.  I'm
not actually looking at the code, or anything :)

The thing to take away is that the #ifdef garbage should be dealt with
by the function and it's prototype in the headers, not by callers.

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2004-06-08 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-06  9:02 [Kernel-janitors] [PATCH] linux-2.6.7-rc2/fs/cifs/cifsfs.c MJK
2004-06-07 16:48 ` Zach Brown
2004-06-08  7:38 ` MJK
2004-06-08 15:49 ` Zach Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40C5E003.1090100@zabbo.net \
    --to=zab@zabbo.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.