* [PATCH] Usb gadget drivers 2.4 kernel
@ 2004-06-14 13:32 John Carlson
2004-06-16 0:13 ` [linux-usb-devel] " David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: John Carlson @ 2004-06-14 13:32 UTC (permalink / raw)
To: linux-usb-devel, linux-kernel
While developing a gadget driver for the 2.4 kernel, I
discovered this error in the gadget driver. This bug
has been present since the gadget driver was back
ported from the 2.6 kernel.
diff -urN
linux-2.4.27-pre5/drivers/usb/gadget/config.c
linux-2.4.27-test/drivers/usb/gadget/config.c
--- linux-2.4.27-pre5/drivers/usb/gadget/config.c
2004-06-14 09:06:48.000000000
-0400
+++ linux-2.4.27-test/drivers/usb/gadget/config.c
2004-06-14 09:13:02.000000000
-0400
@@ -51,7 +51,7 @@
for (; 0 != *src; src++) {
unsigned len =
(*src)->bLength;
- if (len > buflen);
+ if (len > buflen)
return -EINVAL;
memcpy(dest, *src, len);
buflen -= len;
John Carlson <carlsonj@lexmark.com>
__________________________________
Do you Yahoo!?
Friends. Fun. Try the all-new Yahoo! Messenger.
http://messenger.yahoo.com/
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [linux-usb-devel] [PATCH] Usb gadget drivers 2.4 kernel
2004-06-14 13:32 [PATCH] Usb gadget drivers 2.4 kernel John Carlson
@ 2004-06-16 0:13 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2004-06-16 0:13 UTC (permalink / raw)
To: John Carlson; +Cc: linux-usb-devel, linux-kernel
John Carlson wrote:
> While developing a gadget driver for the 2.4 kernel, I
> discovered this error in the gadget driver. This bug
> has been present since the gadget driver was back
> ported from the 2.6 kernel.
Actually, it's just that one source file (config.c),
and the fix is in the gadget-2.4 tree already. I'll
have to resubmit this one, it's rather annoying to
anyone trying to make sure their new hardware works!
- Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-06-16 0:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-14 13:32 [PATCH] Usb gadget drivers 2.4 kernel John Carlson
2004-06-16 0:13 ` [linux-usb-devel] " David Brownell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.