All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timothy Miller <miller@techsource.com>
To: Jurriaan <thunder7@xs4all.nl>
Cc: David Eger <eger@havoc.gtf.org>,
	linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: accelerated radeonfb produces artifacts on scrolling in 2.6.7
Date: Thu, 17 Jun 2004 09:51:07 -0400	[thread overview]
Message-ID: <40D1A1CB.7090301@techsource.com> (raw)
In-Reply-To: <20040616195210.GA26935@middle.of.nowhere>



Jurriaan wrote:

>>Is this the case even with the off-by-one error in the bitblt code 
>>fixed?  In the 2.4 kernel, I got rid of all artifacts by fixing the 
>>off-by-one error.

> You mean this code? I see (w-1) and (h-1) in there.


> 
> 	if ( xdir < 0 ) { sx += w-1; dx += w-1; }
> 	if ( ydir < 0 ) { sy += h-1; dy += h-1; }


Yes, that's the code, and it's correct.



-------------------------------------------------------
This SF.Net email is sponsored by The 2004 JavaOne(SM) Conference
Learn from the experts at JavaOne(SM), Sun's Worldwide Java Developer
Conference, June 28 - July 1 at the Moscone Center in San Francisco, CA
REGISTER AND SAVE! http://java.sun.com/javaone/sf Priority Code NWMGYKND

WARNING: multiple messages have this Message-ID (diff)
From: Timothy Miller <miller@techsource.com>
To: Jurriaan <thunder7@xs4all.nl>
Cc: David Eger <eger@havoc.gtf.org>,
	linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] accelerated radeonfb produces artifacts on scrolling in 2.6.7
Date: Thu, 17 Jun 2004 09:51:07 -0400	[thread overview]
Message-ID: <40D1A1CB.7090301@techsource.com> (raw)
In-Reply-To: <20040616195210.GA26935@middle.of.nowhere>



Jurriaan wrote:

>>Is this the case even with the off-by-one error in the bitblt code 
>>fixed?  In the 2.4 kernel, I got rid of all artifacts by fixing the 
>>off-by-one error.

> You mean this code? I see (w-1) and (h-1) in there.


> 
> 	if ( xdir < 0 ) { sx += w-1; dx += w-1; }
> 	if ( ydir < 0 ) { sy += h-1; dy += h-1; }


Yes, that's the code, and it's correct.


  reply	other threads:[~2004-06-17 13:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-16 18:24 accelerated radeonfb produces artifacts on scrolling in 2.6.7 Jurriaan
2004-06-16 18:24 ` Jurriaan
2004-06-16 18:41 ` David Eger
2004-06-16 18:41   ` [Linux-fbdev-devel] " David Eger
2004-06-16 19:55   ` Timothy Miller
2004-06-16 19:55     ` [Linux-fbdev-devel] " Timothy Miller
2004-06-16 19:52     ` Jurriaan
2004-06-16 19:52       ` [Linux-fbdev-devel] " Jurriaan
2004-06-17 13:51       ` Timothy Miller [this message]
2004-06-17 13:51         ` Timothy Miller
2004-06-17  2:21 ` [PATCH] fix radeonfb panning and make it play nice with copyarea() David Eger
2004-06-17  2:21   ` David Eger
2004-06-17  5:19   ` Jurriaan
2004-06-17  5:19     ` Jurriaan
2004-06-17  5:35     ` David Eger
2004-06-17  5:35       ` David Eger
2004-06-17  5:47     ` David Eger
     [not found]       ` <20040618110450.GA2771@middle.of.nowhere>
2004-06-25  7:18         ` [PATCH] radeonfb: 16bpp accel broken. a work-around David Eger
2004-06-25  7:26           ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40D1A1CB.7090301@techsource.com \
    --to=miller@techsource.com \
    --cc=eger@havoc.gtf.org \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thunder7@xs4all.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.