All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ed Wildgoose <lists@wildgooses.com>
To: lartc@vger.kernel.org
Subject: Re: [LARTC] patch: HTB update for ADSL users
Date: Sat, 19 Jun 2004 13:40:08 +0000	[thread overview]
Message-ID: <40D44238.8080203@wildgooses.com> (raw)
In-Reply-To: <40D2D5CB.2000804@wildgooses.com>

syrius.ml@no-log.org wrote:

>Ed Wildgoose <lists@wildgooses.com> writes:
>
>  
>
>>I would be interested to hear if anyone has a CBQ based setup and can
>>tell me if that patch works for them?  Or even whether it works on the
>>incoming policer properly?
>>    
>>
>
>Would that work with HFSC ?
>  
>

To be honest, I can't see these bits of code being used in HFSC, so I 
doubt it.  However, if performance isn't an issue, it would be fairly 
easy to patch the enqueue function in any of these schedulers to just 
lie about the size of the packet.

>what about PPPoE ? i didn't really understand what I have to change if
>I'm using PPPoE and MTU\x1492.
>  
>

I'm not really sure how PPPoE is working?  Is it as simple as wrapping 
IP in IP? 

The patch is trivial though, the first interesting line is this one:
    + sz = sz + proto_overhead;

Here we just lie about the size of the packet and add the overhead PPP 
causes (this is per original packet)

The next interesting line is this:
    +  sz = (  (int)((sz-1)/encaps_data_sz) + 1) * encaps_cell_sz;

All we are doing is dividing by the size of the packet that our data is 
encapsulated in, (perhaps in your case, encaps_data_sz should be 1492 
?).  Then we multiply up by the actual size of the packet when it 
crosses the link "encaps_cell_size".  Perhaps in your case this should 
be 1492 + 40 = 1532 ?

The other lines were just trying to make it look a little neater.

I will look up how PPPoE works and suggest some new values

Ed W

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

  parent reply	other threads:[~2004-06-19 13:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-18 11:45 [LARTC] patch: HTB update for ADSL users Ed Wildgoose
2004-06-18 21:43 ` Andy Furniss
2004-06-18 23:00 ` Ed Wildgoose
2004-06-19  0:33 ` Andy Furniss
2004-06-19 12:29 ` Ed Wildgoose
2004-06-19 12:54 ` syrius.ml
2004-06-19 13:40 ` Ed Wildgoose [this message]
2004-06-20  7:27 ` Jason Boxman
2004-06-20 12:31 ` Andy Furniss
2004-06-20 13:16 ` Ed Wildgoose
2004-06-20 16:46 ` Ed Wildgoose
2004-06-20 17:10 ` Ed Wildgoose
2004-06-21  6:08 ` Jason Boxman
2004-06-21 10:04 ` Ed Wildgoose
2004-06-22  0:38 ` Damion de Soto
2004-06-22  5:15 ` Jason Boxman
2004-06-22  9:54 ` Ed Wildgoose
2004-06-22 10:00 ` Ed Wildgoose
2004-06-22 17:16 ` Jason Boxman
2004-06-22 21:52 ` Jason Boxman
2004-06-23 12:52 ` ThE LinuX_KiD
2004-06-23 14:00 ` Ed Wildgoose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40D44238.8080203@wildgooses.com \
    --to=lists@wildgooses.com \
    --cc=lartc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.