From: m.hunold@gmx.de (Michael Hunold)
To: Linus Torvalds <torvalds@osdl.org>
Cc: sensors@stimpy.netroedge.com, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
a.othieno@bluewin.ch
Subject: [PATCH][2.6] drivers/media/video/tda9840.c: honour return code of
Date: Thu, 19 May 2005 06:25:02 +0000 [thread overview]
Message-ID: <40D85585.1060608@gmx.de> (raw)
Hello Linus,
i2c_add_driver() may actually fail, but my driver returns 0
regardless. Thanks to Arthur Othieno <a.othieno@bluewin.ch> for this
obviously correct patch.
Signed-off-by: Michael Hunold <hunold@linuxtv.org>
Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch>
tda9840.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/media/video/tda9840.c 2003-12-18 03:59:06.000000000 +0100
+++ b/drivers/media/video/tda9840.c 2004-06-04 18:15:25.000000000 +0200
@@ -268,13 +268,12 @@ static struct i2c_driver driver = {
.command = tda9840_command,
};
-static int tda9840_init_module(void)
+static int __init tda9840_init_module(void)
{
- i2c_add_driver(&driver);
- return 0;
+ return i2c_add_driver(&driver);
}
-static void tda9840_cleanup_module(void)
+static void __exit tda9840_cleanup_module(void)
{
i2c_del_driver(&driver);
}
WARNING: multiple messages have this Message-ID (diff)
From: Michael Hunold <m.hunold@gmx.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: sensors@stimpy.netroedge.com, Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
a.othieno@bluewin.ch
Subject: [PATCH][2.6] drivers/media/video/tda9840.c: honour return code of i2c_add_driver()
Date: Tue, 22 Jun 2004 17:51:33 +0200 [thread overview]
Message-ID: <40D85585.1060608@gmx.de> (raw)
Hello Linus,
i2c_add_driver() may actually fail, but my driver returns 0
regardless. Thanks to Arthur Othieno <a.othieno@bluewin.ch> for this
obviously correct patch.
Signed-off-by: Michael Hunold <hunold@linuxtv.org>
Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch>
tda9840.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/media/video/tda9840.c 2003-12-18 03:59:06.000000000 +0100
+++ b/drivers/media/video/tda9840.c 2004-06-04 18:15:25.000000000 +0200
@@ -268,13 +268,12 @@ static struct i2c_driver driver = {
.command = tda9840_command,
};
-static int tda9840_init_module(void)
+static int __init tda9840_init_module(void)
{
- i2c_add_driver(&driver);
- return 0;
+ return i2c_add_driver(&driver);
}
-static void tda9840_cleanup_module(void)
+static void __exit tda9840_cleanup_module(void)
{
i2c_del_driver(&driver);
}
next reply other threads:[~2005-05-19 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 15:51 Michael Hunold [this message]
2005-05-19 6:25 ` [PATCH][2.6] drivers/media/video/tda9840.c: honour return code of Michael Hunold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D85585.1060608@gmx.de \
--to=m.hunold@gmx.de \
--cc=a.othieno@bluewin.ch \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.