[LARTC] HTB patch - fairness

[LARTC] HTB patch - fairness

[devik]

Witold Szczerba spent his time evaluating fairness of borrowing. His
troubles inspired me enough to analyze the problem: When a class changes
from yellow to green it disconnects itself from parent's feedlist.
Unfortunately it resets feed pointer to the first child. I created a patch
where the class uses classid to remember its position in the feedlist. The
patch for 2.4.24 and hopefully others is at:
http://luxik.cdi.cz/~devik/qos/htb/#changes
PLEASE report me any problems with it !

-------------------------------
    Martin Devera aka devik
Linux kernel QoS/HTB maintainer
  http://luxik.cdi.cz/~devik/


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Re: [LARTC] HTB patch - fairness

[Andy Furniss]

devik wrote:
> Witold Szczerba spent his time evaluating fairness of borrowing. His
> troubles inspired me enough to analyze the problem: When a class changes
> from yellow to green it disconnects itself from parent's feedlist.
> Unfortunately it resets feed pointer to the first child. I created a patch
> where the class uses classid to remember its position in the feedlist. The
> patch for 2.4.24 and hopefully others is at:
> http://luxik.cdi.cz/~devik/qos/htb/#changes
> PLEASE report me any problems with it !
> 

I finally got this to work - I forgot to use gcc 2.59.3 to do the module 
- the one 3.3.3 made segfaulted and stopped tc and ifconfig from working 
  thereafter.

It works - It has fixed the problem pljosh described :-)


Andy.


_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Re: [LARTC] HTB patch - fairness

[Andy Furniss]

Andy Furniss wrote:

> 
> I finally got this to work - I forgot to use gcc 2.59.3 to do the module 
> - the one 3.3.3 made segfaulted and stopped tc and ifconfig from working 
>  thereafter.
> 

I tested and found that the same happens without the patch.

> It works - It has fixed the problem pljosh described :-)

_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/

Re: [LARTC] HTB patch - fairness

[Andre Correa]

Hi Devik, I played with your htbfair patch on 2.6.6 and found some 
diferences between 2.4 to 2.6 that cause problems when applying it. 
Diferences include rb_node that was rb_node_t and some other minor probs.

After "fixing" those diff troubles I still get the following error 
compiling the kernel that I couldn't repair:

make[1]: `arch/i386/kernel/asm-offsets.s' is up to date.
   CHK     include/linux/compile.h
   CC      net/sched/sch_htb.o
net/sched/sch_htb.c:916: parse error before `*'
net/sched/sch_htb.c:917: parse error before `rb_node'
net/sched/sch_htb.c:918: warning: return-type defaults to `int'
net/sched/sch_htb.c:918: warning: function declaration isn't a prototype
net/sched/sch_htb.c: In function `htb_id_find_next_upper':
net/sched/sch_htb.c:919: `rb_node' undeclared (first use in this function)
net/sched/sch_htb.c:919: (Each undeclared identifier is reported only once
net/sched/sch_htb.c:919: for each function it appears in.)
net/sched/sch_htb.c:919: `r' undeclared (first use in this function)
net/sched/sch_htb.c:920: `n' undeclared (first use in this function)
net/sched/sch_htb.c:921: `prio' undeclared (first use in this function)
net/sched/sch_htb.c:922: `id' undeclared (first use in this function)
net/sched/sch_htb.c:931: warning: control reaches end of non-void function
net/sched/sch_htb.c: In function `htb_lookup_leaf':
net/sched/sch_htb.c:951: `pid' undeclared (first use in this function)
net/sched/sch_htb.c:954: `q' undeclared (first use in this function)
net/sched/sch_htb.c:959: warning: assignment from incompatible pointer type
net/sched/sch_htb.c: In function `htb_dequeue_tree':
net/sched/sch_htb.c:996: warning: passing arg 1 of `htb_lookup_leaf' 
from incompatible pointer type
net/sched/sch_htb.c:996: warning: passing arg 2 of `htb_lookup_leaf' 
makes integer from pointer without a cast
net/sched/sch_htb.c:996: warning: passing arg 3 of `htb_lookup_leaf' 
makes pointer from integer without a cast
net/sched/sch_htb.c:996: too many arguments to function `htb_lookup_leaf'
net/sched/sch_htb.c:1018: warning: passing arg 1 of `htb_lookup_leaf' 
from incompatible pointer type
net/sched/sch_htb.c:1018: warning: passing arg 2 of `htb_lookup_leaf' 
makes integer from pointer without a cast
net/sched/sch_htb.c:1018: warning: passing arg 3 of `htb_lookup_leaf' 
makes pointer from integer without a cast
net/sched/sch_htb.c:1018: too many arguments to function `htb_lookup_leaf'
net/sched/sch_htb.c:1034: warning: passing arg 1 of `htb_lookup_leaf' 
from incompatible pointer type
net/sched/sch_htb.c:1034: warning: passing arg 2 of `htb_lookup_leaf' 
makes integer from pointer without a cast
net/sched/sch_htb.c:1034: warning: passing arg 3 of `htb_lookup_leaf' 
makes pointer from integer without a cast
net/sched/sch_htb.c:1034: too many arguments to function `htb_lookup_leaf'
make[2]: *** [net/sched/sch_htb.o] Error 1
make[1]: *** [net/sched] Error 2
make: *** [net] Error 2


The "fixed" patch for 2.6.6 can be downloaded here:

http://www.linuximq.net/testing/htbfair-2.6.6-testing.diff


tks for the good work on HTB.

cheers...

Andre



devik wrote:
> Witold Szczerba spent his time evaluating fairness of borrowing. His
> troubles inspired me enough to analyze the problem: When a class changes
> from yellow to green it disconnects itself from parent's feedlist.
> Unfortunately it resets feed pointer to the first child. I created a patch
> where the class uses classid to remember its position in the feedlist. The
> patch for 2.4.24 and hopefully others is at:
> http://luxik.cdi.cz/~devik/qos/htb/#changes
> PLEASE report me any problems with it !
> 
> -------------------------------
>     Martin Devera aka devik
> Linux kernel QoS/HTB maintainer
>   http://luxik.cdi.cz/~devik/
> 
> 
> _______________________________________________
> LARTC mailing list / LARTC@mailman.ds9a.nl
> http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/
> 
> 
_______________________________________________
LARTC mailing list / LARTC@mailman.ds9a.nl
http://mailman.ds9a.nl/mailman/listinfo/lartc HOWTO: http://lartc.org/