All of lore.kernel.org
 help / color / mirror / Atom feed
* [BK-Patch] ST3160023AS needs mod15
@ 2004-07-02 15:50 Ricky Beam
  2004-07-02 16:07 ` Jeff Garzik
  2004-07-02 16:23 ` James Courtier-Dutton
  0 siblings, 2 replies; 5+ messages in thread
From: Ricky Beam @ 2004-07-02 15:50 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: linux-ide

This BitKeeper patch contains the following changesets:
1.1414

# This is a BitKeeper patch.  What follows are the unified diffs for the
# set of deltas contained in the patch.  The rest of the patch, the part
# that BitKeeper cares about, is below these diffs.
# User:	jfbeam
# Host:	troz.com
# Root:	/opt/kernel/src/bk-linux-2.6

#
#--- 1.27/drivers/scsi/sata_sil.c	2004-06-22 20:42:10 -04:00
#+++ 1.28/drivers/scsi/sata_sil.c	2004-07-02 11:42:45 -04:00
#@@ -86,6 +86,7 @@
# 	{ "ST360015AS",		SIL_QUIRK_MOD15WRITE },
# 	{ "ST380023AS",		SIL_QUIRK_MOD15WRITE },
# 	{ "ST3120023AS",	SIL_QUIRK_MOD15WRITE },
#+	{ "ST3160023AS",	SIL_QUIRK_MOD15WRITE },
# 	{ "ST340014ASL",	SIL_QUIRK_MOD15WRITE },
# 	{ "ST360014ASL",	SIL_QUIRK_MOD15WRITE },
# 	{ "ST380011ASL",	SIL_QUIRK_MOD15WRITE },
#

# Diff checksum=b1066f06


# Patch vers:	1.3
# Patch type:	REGULAR

== ChangeSet ==
torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
jfbeam@spacemeat.troz.com|ChangeSet|20040702041255|33131
D 1.1414 04/07/02 11:42:52-04:00 jfbeam@troz.com +1 -0
B torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
C
c [PATCH] sata_sil: Add ST3160023AS for mod15
c
c Signed-off-by: Ricky Beam <jfbeam@troz.com>
K 32905
P ChangeSet
------------------------------------------------

0a0
> jgarzik@redhat.com|drivers/scsi/sata_sil.c|20031021232136|13432|e65affa611eb11bd jfbeam@troz.com|drivers/scsi/sata_sil.c|20040702154245|50292

== drivers/scsi/sata_sil.c ==
jgarzik@redhat.com|drivers/scsi/sata_sil.c|20031021232136|13432|e65affa611eb11bd
jgarzik@pobox.com|drivers/scsi/sata_sil.c|20040623004210|47591
D 1.28 04/07/02 11:42:45-04:00 jfbeam@troz.com +1 -0
B torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
C
c add ST3160023AS to blacklist
K 50292
O -rw-rw-r--
P drivers/scsi/sata_sil.c
------------------------------------------------

I88 1
	{ "ST3160023AS",	SIL_QUIRK_MOD15WRITE },

# Patch checksum=52314a1b


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BK-Patch] ST3160023AS needs mod15
  2004-07-02 15:50 [BK-Patch] ST3160023AS needs mod15 Ricky Beam
@ 2004-07-02 16:07 ` Jeff Garzik
  2004-07-02 16:23 ` James Courtier-Dutton
  1 sibling, 0 replies; 5+ messages in thread
From: Jeff Garzik @ 2004-07-02 16:07 UTC (permalink / raw)
  To: Ricky Beam; +Cc: linux-ide

Ricky Beam wrote:
> This BitKeeper patch contains the following changesets:
> 1.1414
> 
> # This is a BitKeeper patch.  What follows are the unified diffs for the
> # set of deltas contained in the patch.  The rest of the patch, the part
> # that BitKeeper cares about, is below these diffs.
> # User:	jfbeam
> # Host:	troz.com
> # Root:	/opt/kernel/src/bk-linux-2.6
> 
> #
> #--- 1.27/drivers/scsi/sata_sil.c	2004-06-22 20:42:10 -04:00
> #+++ 1.28/drivers/scsi/sata_sil.c	2004-07-02 11:42:45 -04:00
> #@@ -86,6 +86,7 @@
> # 	{ "ST360015AS",		SIL_QUIRK_MOD15WRITE },
> # 	{ "ST380023AS",		SIL_QUIRK_MOD15WRITE },
> # 	{ "ST3120023AS",	SIL_QUIRK_MOD15WRITE },
> #+	{ "ST3160023AS",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST340014ASL",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST360014ASL",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST380011ASL",	SIL_QUIRK_MOD15WRITE },


I'll apply this, but...  for what it's worth, a simple patch is 
preferred.  These bkpatches are crap :(  [not your fault]

	Jeff



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BK-Patch] ST3160023AS needs mod15
  2004-07-02 16:23 ` James Courtier-Dutton
@ 2004-07-02 16:22   ` Ricky Beam
  2004-07-02 16:48   ` Bartlomiej Zolnierkiewicz
  1 sibling, 0 replies; 5+ messages in thread
From: Ricky Beam @ 2004-07-02 16:22 UTC (permalink / raw)
  To: James Courtier-Dutton; +Cc: Jeff Garzik, linux-ide

On Fri, 2 Jul 2004, James Courtier-Dutton wrote:
>What does SIL_QUIRK_MOD15WRITE do?

Limits max_sectors to 15.  This prevents odd problems with DMA writes to the
drive. (And maybe reads too, but those don't lock up the controller.)

>I have used ST3160023AS for a long time now without any problems in
>kernel 2.6.x

What's that drives firmware revision? (dmesg, eg.)

  Vendor: ATA       Model: ST3160023AS       Rev: 3.18
  Type:   Direct-Access                      ANSI SCSI revision: 05

--Ricky



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BK-Patch] ST3160023AS needs mod15
  2004-07-02 15:50 [BK-Patch] ST3160023AS needs mod15 Ricky Beam
  2004-07-02 16:07 ` Jeff Garzik
@ 2004-07-02 16:23 ` James Courtier-Dutton
  2004-07-02 16:22   ` Ricky Beam
  2004-07-02 16:48   ` Bartlomiej Zolnierkiewicz
  1 sibling, 2 replies; 5+ messages in thread
From: James Courtier-Dutton @ 2004-07-02 16:23 UTC (permalink / raw)
  To: Ricky Beam; +Cc: Jeff Garzik, linux-ide

Ricky Beam wrote:
> This BitKeeper patch contains the following changesets:
> 1.1414
> 
> # This is a BitKeeper patch.  What follows are the unified diffs for the
> # set of deltas contained in the patch.  The rest of the patch, the part
> # that BitKeeper cares about, is below these diffs.
> # User:	jfbeam
> # Host:	troz.com
> # Root:	/opt/kernel/src/bk-linux-2.6
> 
> #
> #--- 1.27/drivers/scsi/sata_sil.c	2004-06-22 20:42:10 -04:00
> #+++ 1.28/drivers/scsi/sata_sil.c	2004-07-02 11:42:45 -04:00
> #@@ -86,6 +86,7 @@
> # 	{ "ST360015AS",		SIL_QUIRK_MOD15WRITE },
> # 	{ "ST380023AS",		SIL_QUIRK_MOD15WRITE },
> # 	{ "ST3120023AS",	SIL_QUIRK_MOD15WRITE },
> #+	{ "ST3160023AS",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST340014ASL",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST360014ASL",	SIL_QUIRK_MOD15WRITE },
> # 	{ "ST380011ASL",	SIL_QUIRK_MOD15WRITE },
> #
> 
> # Diff checksum=b1066f06
> 
> 
> # Patch vers:	1.3
> # Patch type:	REGULAR
> 
> == ChangeSet ==
> torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
> jfbeam@spacemeat.troz.com|ChangeSet|20040702041255|33131
> D 1.1414 04/07/02 11:42:52-04:00 jfbeam@troz.com +1 -0
> B torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
> C
> c [PATCH] sata_sil: Add ST3160023AS for mod15
> c
> c Signed-off-by: Ricky Beam <jfbeam@troz.com>
> K 32905
> P ChangeSet
> ------------------------------------------------
> 
> 0a0
> 
>>jgarzik@redhat.com|drivers/scsi/sata_sil.c|20031021232136|13432|e65affa611eb11bd jfbeam@troz.com|drivers/scsi/sata_sil.c|20040702154245|50292
> 
> 
> == drivers/scsi/sata_sil.c ==
> jgarzik@redhat.com|drivers/scsi/sata_sil.c|20031021232136|13432|e65affa611eb11bd
> jgarzik@pobox.com|drivers/scsi/sata_sil.c|20040623004210|47591
> D 1.28 04/07/02 11:42:45-04:00 jfbeam@troz.com +1 -0
> B torvalds@athlon.transmeta.com|ChangeSet|20020205173056|16047|c1d11a41ed024864
> C
> c add ST3160023AS to blacklist
> K 50292
> O -rw-rw-r--
> P drivers/scsi/sata_sil.c
> ------------------------------------------------
> 
> I88 1
> 	{ "ST3160023AS",	SIL_QUIRK_MOD15WRITE },
> 
> # Patch checksum=52314a1b
> 

What does SIL_QUIRK_MOD15WRITE do?
I have used ST3160023AS for a long time now without any problems in 
kernel 2.6.x

It would be nice if the "hdparm -I /dev/sda" would work(or something 
similar) on the libata driver, just like it worked on the PATA driver.
Does anyone know how to do it?

James



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [BK-Patch] ST3160023AS needs mod15
  2004-07-02 16:23 ` James Courtier-Dutton
  2004-07-02 16:22   ` Ricky Beam
@ 2004-07-02 16:48   ` Bartlomiej Zolnierkiewicz
  1 sibling, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2004-07-02 16:48 UTC (permalink / raw)
  To: James Courtier-Dutton, Ricky Beam; +Cc: Jeff Garzik, linux-ide

On Friday 02 of July 2004 18:23, James Courtier-Dutton wrote:

> What does SIL_QUIRK_MOD15WRITE do?
> I have used ST3160023AS for a long time now without any problems in
> kernel 2.6.x

Do you have Silicon Image controller?  Are you using sata_sil driver?

If not this issue+patch doesn't affect you.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2004-07-02 16:43 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-02 15:50 [BK-Patch] ST3160023AS needs mod15 Ricky Beam
2004-07-02 16:07 ` Jeff Garzik
2004-07-02 16:23 ` James Courtier-Dutton
2004-07-02 16:22   ` Ricky Beam
2004-07-02 16:48   ` Bartlomiej Zolnierkiewicz

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.