All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Veeck <michael.veeck@gmx.net>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Kernel-janitors] min/max macros from kernel.h
Date: Sun, 04 Jul 2004 14:00:43 +0000	[thread overview]
Message-ID: <40E95E2E.5030500@gmx.net> (raw)
In-Reply-To: <20040704114015.GA5381@moley.homelinux.net>

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]



Clemens Buchacher wrote:
> I've replaced the custom MIN/MAX macros in drivers/ide/ide-timing.h with
> the corresponding min/max macros from kernel.h, as suggested by the TODO
> list.

One advice: Before doing stuff on the todo list, ask on the mailing list 
if anybodys working on it. This could save you some time.

Otherwise the patch looks good to me, but next time also tell against 
which version it is. 2.6.7 I presume?

Greetings,
Veeck

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2004-07-04 14:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-04 11:40 [Kernel-janitors] min/max macros from kernel.h Clemens Buchacher
2004-07-04 14:00 ` Michael Veeck [this message]
2004-07-05 14:04 ` maximilian attems
2004-07-10 13:53 ` Clemens Buchacher
2004-07-10 14:00 ` Clemens Buchacher
2004-07-11 10:13 ` Michael Veeck
2004-07-11 10:55 ` maximilian attems
2004-07-11 11:27 ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40E95E2E.5030500@gmx.net \
    --to=michael.veeck@gmx.net \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.