From: Will Beers <whbeers@mbio.ncsu.edu>
To: David Brownell <david-b@pacbell.net>
Cc: Olaf Hering <olh@suse.de>,
Gary_Lerhaupt@Dell.com, linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Stuart_Hayes@Dell.com
Subject: Re: [linux-usb-devel] [PATCH] proper bios handoff in ehci-hcd
Date: Tue, 13 Jul 2004 17:24:55 -0400 [thread overview]
Message-ID: <40F45327.1080703@mbio.ncsu.edu> (raw)
In-Reply-To: <40F44FFB.80707@pacbell.net>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
> Sounds to me like your BIOS may be broken. But if you're
> up for it, you could try using byte access to write that one
Changing the pci_read_config to a byte access fixes it, thanks!
(included a diff)
-Will
diff -Nru a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
--- a/drivers/usb/host/ehci-hcd.c 2004-07-13 01:09:00.000000000 -0400
+++ b/drivers/usb/host/ehci-hcd.c 2004-07-13 17:06:00.000000000 -0400
@@ -300,7 +300,7 @@
do {
msleep(10);
msec -= 10;
- pci_read_config_dword(pdev, where, &cap);
+ pci_read_config_byte(pdev, where, &cap);
} while ((cap & (1 << 16)) && msec);
if (cap & (1 << 16)) {
ehci_err (ehci, "BIOS handoff failed (%d, %04x)\n",
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 3186 bytes --]
next prev parent reply other threads:[~2004-07-13 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-14 20:30 [PATCH] proper bios handoff in ehci-hcd Gary_Lerhaupt
2004-06-15 13:57 ` [linux-usb-devel] " David Brownell
2004-07-13 5:30 ` Will Beers
[not found] ` <200407130744.22920.andjoh@rydsbo.net>
2004-07-13 6:16 ` Will Beers
2004-07-13 18:07 ` [linux-usb-devel] " Olaf Hering
2004-07-13 20:26 ` David Brownell
2004-07-13 20:44 ` Will Beers
2004-07-13 21:11 ` David Brownell
2004-07-13 21:24 ` Will Beers [this message]
2004-07-13 21:35 ` David Brownell
2004-07-13 21:43 ` Will Beers
2004-07-13 21:31 ` Will Beers
-- strict thread matches above, loose matches on Subject: below --
2004-07-13 20:52 Stuart_Hayes
2004-07-13 21:56 ` Pete Zaitcev
2004-07-13 23:04 ` David Brownell
2004-07-15 9:37 ` Olaf Hering
2004-08-05 13:39 ` Olaf Hering
2004-08-05 15:49 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F45327.1080703@mbio.ncsu.edu \
--to=whbeers@mbio.ncsu.edu \
--cc=Gary_Lerhaupt@Dell.com \
--cc=Stuart_Hayes@Dell.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.