All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-afs@lists.infradead.org
Subject: Re: [Intel-gfx] [PATCH 03/13] scatterlist: Add sg_set_folio()
Date: Sun, 30 Jul 2023 21:57:06 +0800	[thread overview]
Message-ID: <40a3ab47-da3e-0d08-b3fa-b4663f3e727d@linux.dev> (raw)
In-Reply-To: <ZMZHH5Xc507OZA1O@casper.infradead.org>


在 2023/7/30 19:18, Matthew Wilcox 写道:
> On Sun, Jul 30, 2023 at 07:01:26PM +0800, Zhu Yanjun wrote:
>> Does the following function have folio version?
>>
>> "
>> int sg_alloc_append_table_from_pages(struct sg_append_table *sgt_append,
>> 		struct page **pages, unsigned int n_pages, unsigned int offset,
>> 		unsigned long size, unsigned int max_segment,
>> 		unsigned int left_pages, gfp_t gfp_mask)
>> "
> No -- I haven't needed to convert anything that uses
> sg_alloc_append_table_from_pages() yet.  It doesn't look like it should
> be _too_ hard to add a folio version.

In many places, this function is used. So this function needs the folio 
version.

Another problem, after folio is used, I want to know the performance 
after folio is implemented.

How to make tests to get the performance?

Thanks a lot.

Zhu Yanjun


WARNING: multiple messages have this Message-ID (diff)
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, linux-afs@lists.infradead.org,
	linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 03/13] scatterlist: Add sg_set_folio()
Date: Sun, 30 Jul 2023 21:57:06 +0800	[thread overview]
Message-ID: <40a3ab47-da3e-0d08-b3fa-b4663f3e727d@linux.dev> (raw)
In-Reply-To: <ZMZHH5Xc507OZA1O@casper.infradead.org>


在 2023/7/30 19:18, Matthew Wilcox 写道:
> On Sun, Jul 30, 2023 at 07:01:26PM +0800, Zhu Yanjun wrote:
>> Does the following function have folio version?
>>
>> "
>> int sg_alloc_append_table_from_pages(struct sg_append_table *sgt_append,
>> 		struct page **pages, unsigned int n_pages, unsigned int offset,
>> 		unsigned long size, unsigned int max_segment,
>> 		unsigned int left_pages, gfp_t gfp_mask)
>> "
> No -- I haven't needed to convert anything that uses
> sg_alloc_append_table_from_pages() yet.  It doesn't look like it should
> be _too_ hard to add a folio version.

In many places, this function is used. So this function needs the folio 
version.

Another problem, after folio is used, I want to know the performance 
after folio is implemented.

How to make tests to get the performance?

Thanks a lot.

Zhu Yanjun


WARNING: multiple messages have this Message-ID (diff)
From: Zhu Yanjun <yanjun.zhu@linux.dev>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-afs@lists.infradead.org
Subject: Re: [PATCH 03/13] scatterlist: Add sg_set_folio()
Date: Sun, 30 Jul 2023 21:57:06 +0800	[thread overview]
Message-ID: <40a3ab47-da3e-0d08-b3fa-b4663f3e727d@linux.dev> (raw)
In-Reply-To: <ZMZHH5Xc507OZA1O@casper.infradead.org>


在 2023/7/30 19:18, Matthew Wilcox 写道:
> On Sun, Jul 30, 2023 at 07:01:26PM +0800, Zhu Yanjun wrote:
>> Does the following function have folio version?
>>
>> "
>> int sg_alloc_append_table_from_pages(struct sg_append_table *sgt_append,
>> 		struct page **pages, unsigned int n_pages, unsigned int offset,
>> 		unsigned long size, unsigned int max_segment,
>> 		unsigned int left_pages, gfp_t gfp_mask)
>> "
> No -- I haven't needed to convert anything that uses
> sg_alloc_append_table_from_pages() yet.  It doesn't look like it should
> be _too_ hard to add a folio version.

In many places, this function is used. So this function needs the folio 
version.

Another problem, after folio is used, I want to know the performance 
after folio is implemented.

How to make tests to get the performance?

Thanks a lot.

Zhu Yanjun


  reply	other threads:[~2023-07-31 13:27 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 16:45 [Intel-gfx] [PATCH 00/13] Remove pagevecs Matthew Wilcox (Oracle)
2023-06-21 16:45 ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 01/13] afs: Convert pagevec to folio_batch in afs_extend_writeback() Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 02/13] mm: Add __folio_batch_release() Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 03/13] scatterlist: Add sg_set_folio() Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-07-30 11:01   ` [Intel-gfx] " Zhu Yanjun
2023-07-30 11:01     ` Zhu Yanjun
2023-07-30 11:01     ` Zhu Yanjun
2023-07-30 11:18     ` [Intel-gfx] " Matthew Wilcox
2023-07-30 11:18       ` Matthew Wilcox
2023-07-30 11:18       ` Matthew Wilcox
2023-07-30 13:57       ` Zhu Yanjun [this message]
2023-07-30 13:57         ` Zhu Yanjun
2023-07-30 13:57         ` Zhu Yanjun
2023-07-30 21:42         ` [Intel-gfx] " Matthew Wilcox
2023-07-30 21:42           ` Matthew Wilcox
2023-07-30 21:42           ` Matthew Wilcox
2023-08-18  7:05           ` [Intel-gfx] " Zhu Yanjun
2023-08-18  7:05             ` Zhu Yanjun
2023-08-18  7:05             ` Zhu Yanjun
2023-06-21 16:45 ` [Intel-gfx] [PATCH 04/13] i915: Convert shmem_sg_free_table() to use a folio_batch Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 05/13] drm: Convert drm_gem_put_pages() " Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 06/13] mm: Remove check_move_unevictable_pages() Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 07/13] pagevec: Rename fbatch_count() Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 08/13] i915: Convert i915_gpu_error to use a folio_batch Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 09/13] net: Convert sunrpc from pagevec to folio_batch Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 17:50   ` [Intel-gfx] " Chuck Lever
2023-06-21 17:50     ` Chuck Lever
2023-06-21 17:50     ` Chuck Lever
2023-06-21 16:45 ` [Intel-gfx] [PATCH 10/13] mm: Remove struct pagevec Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 11/13] mm: Rename invalidate_mapping_pagevec to mapping_try_invalidate Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 12/13] mm: Remove references to pagevec Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45 ` [Intel-gfx] [PATCH 13/13] mm: Remove unnecessary pagevec includes Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 16:45   ` Matthew Wilcox (Oracle)
2023-06-21 22:28 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for Remove pagevecs Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40a3ab47-da3e-0d08-b3fa-b4663f3e727d@linux.dev \
    --to=yanjun.zhu@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.