[Kernel-janitors] Re: [PATCH] scsi/ipr: replace schedule_timeout()

[Kernel-janitors] Re: [PATCH] scsi/ipr: replace schedule_timeout()

[Brian King]

[-- Attachment #1: Type: text/plain, Size: 888 bytes --]

Looks good. Thanks. James, please apply.

-Brian

Nishanth Aravamudan wrote:
> I would appreciate any comments from the janitors list. 
> 
> Applys-to: 2.6.7
> 
> Description: Use msleep() instead of schedule_timeout() to 
> guarantee the task delays for the desired time.
> 
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
> 
> 
> --- linux-vanilla/drivers/scsi/ipr.c	2004-06-16 05:20:27.000000000 +0000
> +++ linux-dev/drivers/scsi/ipr.c	2004-07-13 18:06:11.000000000 +0000
> @@ -2007,7 +2007,7 @@ static ssize_t ipr_store_diagnostics(str
>  		wait_event(ioa_cfg->reset_wait_q, !ioa_cfg->in_reset_reload);
>  
>  		/* Wait for a second for any errors to be logged */
> -		schedule_timeout(HZ);
> +		msleep(1000);
>  	} else {
>  		spin_unlock_irqrestore(ioa_cfg->host->host_lock, lock_flags);
>  		return -EIO;
> 

-- 
Brian King
eServer Storage I/O
IBM Linux Technology Center


[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors