* [PATCH 2.6.8-rc2] include/linux/ata.h
@ 2004-07-20 1:04 Andrew Chew
2004-07-28 17:15 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Andrew Chew @ 2004-07-20 1:04 UTC (permalink / raw)
To: linux-kernel; +Cc: B.Zolnierkiewicz, jgarzik
The macros ata_id_has_lba() and ata_id_has_dma() seem to have their bits
reversed. LBA support is bit 9 of word 49 in the identify page, whereas
DMA support is bit 8 of word 49 in the identify page.
--- ata.original.h 2004-07-19 17:49:26.000000000 -0700
+++ ata.h 2004-07-19 17:49:05.000000000 -0700
@@ -209,8 +209,8 @@
#define ata_id_has_lba48(dev) ((dev)->id[83] & (1 << 10))
#define ata_id_has_wcache(dev) ((dev)->id[82] & (1 << 5))
#define ata_id_has_pm(dev) ((dev)->id[82] & (1 << 3))
-#define ata_id_has_lba(dev) ((dev)->id[49] & (1 << 8))
-#define ata_id_has_dma(dev) ((dev)->id[49] & (1 << 9))
+#define ata_id_has_lba(dev) ((dev)->id[49] & (1 << 9))
+#define ata_id_has_dma(dev) ((dev)->id[49] & (1 << 8))
#define ata_id_removeable(dev) ((dev)->id[0] & (1 << 7))
#define ata_id_u32(dev,n) \
(((u32) (dev)->id[(n) + 1] << 16) | ((u32) (dev)->id[(n)]))
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.8-rc2] include/linux/ata.h
2004-07-20 1:04 [PATCH 2.6.8-rc2] include/linux/ata.h Andrew Chew
@ 2004-07-28 17:15 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-07-28 17:15 UTC (permalink / raw)
To: Andrew Chew; +Cc: linux-kernel, B.Zolnierkiewicz
Andrew Chew wrote:
> The macros ata_id_has_lba() and ata_id_has_dma() seem to have their bits
> reversed. LBA support is bit 9 of word 49 in the identify page, whereas
> DMA support is bit 8 of word 49 in the identify page.
>
>
> --- ata.original.h 2004-07-19 17:49:26.000000000 -0700
> +++ ata.h 2004-07-19 17:49:05.000000000 -0700
> @@ -209,8 +209,8 @@
> #define ata_id_has_lba48(dev) ((dev)->id[83] & (1 << 10))
> #define ata_id_has_wcache(dev) ((dev)->id[82] & (1 << 5))
> #define ata_id_has_pm(dev) ((dev)->id[82] & (1 << 3))
> -#define ata_id_has_lba(dev) ((dev)->id[49] & (1 << 8))
> -#define ata_id_has_dma(dev) ((dev)->id[49] & (1 << 9))
> +#define ata_id_has_lba(dev) ((dev)->id[49] & (1 << 9))
> +#define ata_id_has_dma(dev) ((dev)->id[49] & (1 << 8))
> #define ata_id_removeable(dev) ((dev)->id[0] & (1 << 7))
> #define ata_id_u32(dev,n) \
> (((u32) (dev)->id[(n) + 1] << 16) | ((u32) (dev)->id[(n)]))
Patch looks good, but please submit patches generated from the base of
the kernel tree, so that "patch -sp1 < patch" successfully applies your
patch.
I am applying this patch manually...
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-07-28 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-20 1:04 [PATCH 2.6.8-rc2] include/linux/ata.h Andrew Chew
2004-07-28 17:15 ` Jeff Garzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.